-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[components] Preview Toolbar has scrollbar #10207
Comments
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook! |
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks! |
Core: Add global box-sizing setting. Fixes #10207
Zoinks!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.0.0-beta.30 containing PR #11055 that references this issue. Upgrade today to try it out! You can find this prerelease on the |
That PR did not fix this issue—it's still present in the docs view in 6.4.9. Had to add this CSS to preview-head.html to fix: .sbdocs .os-content a {
margin-top: 0 !important;
height: unset !important;
} |
@matheo can you confirm the issue is still present, and if so investigate an improved fix? 🙏 |
We’re cleaning house! Storybook has changed a lot since this issue was created and we don’t know if it’s still valid. Please open a new issue referencing this one if:
|
Describe the bug
The DocsPage Preview component Toolbar has a scrollbar when the IconButton's
box-sizing
is not reset toborder-box
somewhere else.Toolbar has height 40, and IconButton has height: 40 + 3 border
Screenshots
![preview-header](https://user-images.githubusercontent.com/20753323/77467806-e93d6800-6e0c-11ea-9f8d-180619665e6f.png)
The text was updated successfully, but these errors were encountered: