Updates BrowserStorageConfigParams method types #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piyalbasu
approved these changes
Apr 26, 2024
CassioMG
added a commit
that referenced
this pull request
May 20, 2024
* bump version to 1.5.0 * [Soroban] Add getTokenInvocationArgs function in new workspace (#119) * [Soroban] Add token parsing/formatting functions (#120) * [Soroban] Add scValByType function (#121) * [Soroban] Add GH Action and README (#122) * add tests for moneygram transactions (#123) * Use relative path to access "walletSdk" root folder (#125) * add AuthHeaderSigner (#124) * add AuthHeaderSigner * cmments * fix test * print logs * fix * Cleanup * Update @stellar/typescript-wallet-sdk/src/walletSdk/Auth/AuthHeaderSigner.ts Co-authored-by: Cássio Marcos Goulart <3228151+CassioMG@users.noreply.github.com> * snake case * add test for checking against example JWT --------- Co-authored-by: Cássio Marcos Goulart <3228151+CassioMG@users.noreply.github.com> * Add e2e test for testing browser build (#126) * add challengeToken to km header (#127) * add challengeToken to km header * move to dev deps * fix test * [Soroban] Add generic getInvocationDetails helper (#128) * updates BrowserStorageConfigParams method types (#129) * add changelogs, and update package versions to all be in align (#131) * update integration tests readme (#132) * add defaultauthheadersigner test with anchorplatform (#133) * add beta build github action (#135) * add canary build github action * add contributing guide with releasing directions * use timestamp * add top level readme (#136) * add top level readme * update * update * update * update * yarn install * example code * update changelogs (#137) * change to param (#138) --------- Co-authored-by: Alec Charbonneau <aleccharb21@gmail.com> Co-authored-by: Cássio Marcos Goulart <3228151+CassioMG@users.noreply.github.com> Co-authored-by: aristides <aristides@aristidesstaffieri.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Updates the
BrowserStorageConfigParamsto match the previous definition and the webkit polyfill's definitionWhy
While migrating from
@stellar/wallet-sdk, I hit a type error because storage API definitions clash.stellar/freighter#1255