Add e2e test for testing browser build #126
Conversation
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is filesystem access?Accesses the file system, and could potentially read sensitive data. If a package must read the file system, clarify what it will read and ensure it reads only what it claims to. If appropriate, packages can leave file system access to consumers and operate on data passed to it instead. What is debug access?Uses debug, reflection and dynamic code execution features. Removing the use of debug will reduce the risk of any reflection and dynamic code execution. What is network access?This module accesses the network. Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
|
looked into the socket security warnings. They are Medium and Low level warnings for playwright-core. Don't look to be dangerous to me |
|
|
||
| ## browser.test.ts | ||
|
|
||
| This test uses playwright to load the browser bundle file into a browser |
There was a problem hiding this comment.
That's smart! Do you think we should add some minimal sanity chromium/firefox/safari tests in the future?
There was a problem hiding this comment.
ya that's a good idea 👍
it was quick so I just added, added firefox and safari
df1c640
There was a problem hiding this comment.
hmm firefox actually is throwing a weird error, seems to be related with running CI/CD, since it works locally
I added a ticket to look into and add in another PR
https://stellarorg.atlassian.net/browse/WAL-1448
There was a problem hiding this comment.
Maybe you can try to use stable firefox, not nightly?
There was a problem hiding this comment.
just saw this, I think playwright might be using nightly as default? 🤔
there's a thread discussing this error, skimmed it and doesn't look like it's a quick fix. I'll look more into it
* bump version to 1.5.0 * [Soroban] Add getTokenInvocationArgs function in new workspace (#119) * [Soroban] Add token parsing/formatting functions (#120) * [Soroban] Add scValByType function (#121) * [Soroban] Add GH Action and README (#122) * add tests for moneygram transactions (#123) * Use relative path to access "walletSdk" root folder (#125) * add AuthHeaderSigner (#124) * add AuthHeaderSigner * cmments * fix test * print logs * fix * Cleanup * Update @stellar/typescript-wallet-sdk/src/walletSdk/Auth/AuthHeaderSigner.ts Co-authored-by: Cássio Marcos Goulart <3228151+CassioMG@users.noreply.github.com> * snake case * add test for checking against example JWT --------- Co-authored-by: Cássio Marcos Goulart <3228151+CassioMG@users.noreply.github.com> * Add e2e test for testing browser build (#126) * add challengeToken to km header (#127) * add challengeToken to km header * move to dev deps * fix test * [Soroban] Add generic getInvocationDetails helper (#128) * updates BrowserStorageConfigParams method types (#129) * add changelogs, and update package versions to all be in align (#131) * update integration tests readme (#132) * add defaultauthheadersigner test with anchorplatform (#133) * add beta build github action (#135) * add canary build github action * add contributing guide with releasing directions * use timestamp * add top level readme (#136) * add top level readme * update * update * update * update * yarn install * example code * update changelogs (#137) * change to param (#138) --------- Co-authored-by: Alec Charbonneau <aleccharb21@gmail.com> Co-authored-by: Cássio Marcos Goulart <3228151+CassioMG@users.noreply.github.com> Co-authored-by: aristides <aristides@aristidesstaffieri.com>
ticket
this e2e test tests the browser build works, so we don't have to test manually before each release