Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify no value overhaul issues on test coverage #47

Merged
merged 3 commits into from
Mar 24, 2023
Merged

verify no value overhaul issues on test coverage #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b19f82
#41: fixed cli test to use --source=identity, updated readme
sreuland Mar 23, 2023
699eb62
#41, added docs on js client version
sreuland Mar 23, 2023
79cad5a
#41: fixed typo in readme
sreuland Mar 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ SOROBAN_RPC_GIT_REF=https://github.com/stellar/soroban-tools.git\#main
SOROBAN_CLI_GIT_REF=https://github.com/stellar/soroban-tools.git\#main
GO_GIT_REF=https://github.com/stellar/go.git\#soroban-xdr-next
QUICKSTART_GIT_REF=https://github.com/stellar/quickstart.git\#master
# specify the published npm repo version of soroban-client js library, or you can specify gh git ref url as the version also
JS_SOROBAN_CLIENT_NPM_VERSION=https://github.com/stellar/js-soroban-client.git\#main

# variables to set if wanting to use existing dockerhub images instead of compiling
Expand Down
23 changes: 18 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,17 +16,21 @@ To run tests, requires two steps:
GO_GIT_REF=? \
RUST_TOOLCHAIN_VERSION=? \
SOROBAN_CLI_CRATE_VERSION=? \
JS_SOROBAN_CLIENT_NPM_VERSION=? \
NODE_VERSION=? \
build
```

example of build using specific git branches, latest in this case, or use tag names for releases:
example of build using specific git refs, mainline from repos in this example, or use tags, branches, etc:
```
$ make CORE_GIT_REF=https://github.com/stellar/stellar-core#f1dc39f0f146815e5e3a94ed162e2f0639cb433f \
$ make CORE_GIT_REF=https://github.com/stellar/stellar-core.git#f1dc39f0f146815e5e3a94ed162e2f0639cb433f \
CORE_COMPILE_CONFIGURE_FLAGS="--disable-tests --enable-next-protocol-version-unsafe-for-production" \
SOROBAN_RPC_GIT_REF=https://github.com/stellar/soroban-tools#main \
SOROBAN_RPC_GIT_REF=https://github.com/stellar/soroban-tools.git#main \
RUST_TOOLCHAIN_VERSION=stable \
SOROBAN_CLI_GIT_REF=https://github.com/stellar/soroban-tools#main \
QUICKSTART_GIT_REF=https://github.com/stellar/quickstart#master build
SOROBAN_CLI_GIT_REF=https://github.com/stellar/soroban-tools.git#main \
QUICKSTART_GIT_REF=https://github.com/stellar/quickstart.git#master \
JS_SOROBAN_CLIENT_NPM_VERSION=https://github.com/stellar/js-soroban-client.git#main \
build
```

example of build using the existing quickstart:soroban-dev image which has latest released soroban server versions and builds soroban cli from local directory of checked out soroban-tools repo:
Expand All @@ -45,13 +49,22 @@ To run tests, requires two steps:
GO_GIT_REF=https://github.com/stellar/go.git#soroban-xdr-next
CORE_COMPILE_CONFIGURE_FLAGS="--disable-tests --enable-next-protocol-version-unsafe-for-production"
CORE_GIT_REF=https://github.com/stellar/stellar-core.git#master
JS_SOROBAN_CLIENT_NPM_VERSION=https://github.com/stellar/js-soroban-client.git#main
```

optional to set:
```
# this will override SOROBAN_CLI_GIT_REF, and install soroban cli from crates repo instead
SOROBAN_CLI_CRATE_VERSION=0.4.0

# this will override the default Node JS vm version used for running the JS code:
NODE_VERSION=14.20.0

# soroban js client version can be set to a published npm version on https://www.npmjs.com/package/soroban-client
JS_SOROBAN_CLIENT_NPM_VERSION=latest
# or it can be set to a github git ref of a js-soroban-client repo
JS_SOROBAN_CLIENT_NPM_VERSION=https://github.com/stellar/js-soroban-client.git#main

# Image overrides.
# If using these, the image ref should provide a manifiest version for same
# platform arch as the build host is running on, i.e. linux/amd64 or linux/arm64.
Expand Down
2 changes: 1 addition & 1 deletion features/dapp_develop/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ func deployContractUsingConfigParams(compiledContractFileName string, contractWo
"deploy",
"--wasm", fmt.Sprintf("./%s/target/wasm32-unknown-unknown/release/%s", contractWorkingDirectory, compiledContractFileName),
"--network", networkConfigName,
"--identity", identityName)
"--source", identityName)

status, stdOut, err := e2e.RunCommand(envCmd, e2eConfig)

Expand Down