Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify no value overhaul issues on test coverage #47

Merged
merged 3 commits into from
Mar 24, 2023

Conversation

sreuland
Copy link
Contributor

Confirmed that value overhaul changes from latest on tools did not have an effect at system test/client usage level, no errors were found against latest build of tools, tests passed:

$ make CORE_GIT_REF=https://github.com/stellar/stellar-core.git#064a2787acb9e98c70567523785333581ee1ffa4 \
CORE_COMPILE_CONFIGURE_FLAGS="--disable-tests --enable-next-protocol-version-unsafe-for-production" \
SOROBAN_RPC_GIT_REF=https://github.com/stellar/soroban-tools.git#main \
RUST_TOOLCHAIN_VERSION=stable \
SOROBAN_CLI_GIT_REF=https://github.com/stellar/soroban-tools.git#main \
QUICKSTART_GIT_REF=https://github.com/stellar/quickstart.git#master \
build

$ docker run --rm -it --name e2e_test stellar/system-test:dev --VerboseOutput true
...
9 scenarios (9 passed)
53 steps (53 passed)
5m29.556048899s

Did have to make one minor change to fix test failure on now deprecated --identity param.

Closes #41

@sreuland sreuland changed the title verified no value overhaul issues, fix cli test to use --source=identity, updated readme verify no value overhaul issues on test coverage Mar 23, 2023
@sreuland
Copy link
Contributor Author

when this merges, I'll cut new release of system-test and update soroban-tools/e2e to use that.

@sreuland sreuland merged commit 3f54b84 into stellar:master Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Existing tests should pass with newer ScVal model
2 participants