Remove support for old V1 survey #4660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboston7
commented
Mar 4, 2025
marta-lokhova
requested changes
Mar 4, 2025
|
LGTM! I think you need to rebase on top of master to pickup cargo-deny fix, and refresh XDR pointers after the prerequisite PRs are merged. |
Closes stellar#4332. Now that all stellar-core nodes on the network support the V2 survey, and there are no node stellar-core nodes that will generate V1 survey messages, it's safe to cleanup the codebase a bit and remove support for the old V1 survey entirely. This has the benefit of greatly simplifying `SurveyManager`.
90bc0ce to
4126cdd
Compare
marta-lokhova
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4332.
Now that all stellar-core nodes on the network support the V2 survey, and there are no node stellar-core nodes that will generate V1 survey messages, it's safe to cleanup the codebase a bit and remove support for the old V1 survey entirely. This has the benefit of greatly simplifying
SurveyManager.Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)