Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove V1 survey XDR and supporting code #4332

Closed
bboston7 opened this issue May 28, 2024 · 0 comments · Fixed by #4660
Closed

Remove V1 survey XDR and supporting code #4332

bboston7 opened this issue May 28, 2024 · 0 comments · Fixed by #4660
Assignees
@bboston7
Labels
cleanup refactoring or other internal improvements

Comments

@bboston7
Copy link
Contributor

We have deprecated the V1 network survey with the addition of the V2 survey in #4275. Once the network minimum overlay version is 34, we can be sure that all nodes support the V2 survey and we should remove the XDR definitions and supporting code for the V1 survey.
@bboston7 bboston7 added the cleanup refactoring or other internal improvements label May 28, 2024
@bboston7 bboston7 self-assigned this May 28, 2024
@bboston7 bboston7 mentioned this issue May 28, 2024
Closed
This was referenced Mar 4, 2025
Merged
Merged
bboston7 added a commit to bboston7/stellar-core that referenced this issue Mar 4, 2025
@bboston7
Remove support for old V1 survey
965e430 
Closes stellar#4332.

Now that all stellar-core nodes on the network support the V2 survey,
and there are no node stellar-core nodes that will generate V1 survey
messages, it's safe to cleanup the codebase a bit and remove support for
the old V1 survey entirely. This has the benefit of greatly simplifying
`SurveyManager`.
bboston7 added a commit to bboston7/stellar-core that referenced this issue Mar 4, 2025
@bboston7
Remove support for old V1 survey
09177a9 
Closes stellar#4332.

Now that all stellar-core nodes on the network support the V2 survey,
and there are no node stellar-core nodes that will generate V1 survey
messages, it's safe to cleanup the codebase a bit and remove support for
the old V1 survey entirely. This has the benefit of greatly simplifying
`SurveyManager`.
@bboston7 bboston7 mentioned this issue Mar 4, 2025
Merged
6 tasks
bboston7 added a commit to bboston7/stellar-core that referenced this issue Mar 4, 2025
@bboston7
Remove support for old V1 survey
4126cdd 
Closes stellar#4332.

Now that all stellar-core nodes on the network support the V2 survey,
and there are no node stellar-core nodes that will generate V1 survey
messages, it's safe to cleanup the codebase a bit and remove support for
the old V1 survey entirely. This has the benefit of greatly simplifying
`SurveyManager`.
github-merge-queue bot pushed a commit that referenced this issue Mar 5, 2025
@marta-lokhova
Remove support for old V1 survey (#4660)
025b02a 
Closes #4332.

Now that all stellar-core nodes on the network support the V2 survey,
and there are no node stellar-core nodes that will generate V1 survey
messages, it's safe to cleanup the codebase a bit and remove support for
the old V1 survey entirely. This has the benefit of greatly simplifying
`SurveyManager`.

# Checklist
- [x] Reviewed the
[contributing](https://github.com/stellar/stellar-core/blob/master/CONTRIBUTING.md#submitting-changes)
document
- [x] Rebased on top of master (no merge commits)
- [x] Ran `clang-format` v8.0.0 (via `make format` or the Visual Studio
extension)
- [x] Compiles
- [x] Ran all tests
- [ ] If change impacts performance, include supporting evidence per the
[performance
document](https://github.com/stellar/stellar-core/blob/master/performance-eval/performance-eval.md)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bboston7 bboston7

Labels
cleanup refactoring or other internal improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove support for old V1 survey bboston7/stellar-core
2 participants
@bboston7 and others