Add ref Option conversion into ScVal #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36709af to
40f4fa8
Compare
This was referenced Nov 11, 2023
dmkozh
approved these changes
Nov 13, 2023
github-merge-queue bot
pushed a commit
to stellar/rs-soroban-env
that referenced
this pull request
Nov 14, 2023
### What Update stellar-xdr. ### Why To get changes in stellar-xdr that fix Option<T> <> ScVal for: - Close stellar/rs-soroban-sdk#877 - Close #444 Dependent on: - stellar/rs-stellar-xdr#320
github-merge-queue bot
pushed a commit
to stellar/rs-soroban-sdk
that referenced
this pull request
Nov 14, 2023
### What Try to make Option<T> work with contracttype ### Why Close stellar/rs-soroban-env#444 Close #877 Dependent on: - stellar/rs-stellar-xdr#320 - stellar/rs-soroban-env#1198
github-merge-queue bot
pushed a commit
to stellar/rs-soroban-sdk
that referenced
this pull request
Nov 14, 2023
### What Try to make Option<T> work with contracttype ### Why Close stellar/rs-soroban-env#444 Close #877 Dependent on: - stellar/rs-stellar-xdr#320 - stellar/rs-soroban-env#1198
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add ref Option conversion into ScVal.
Why
It's needed for supporting Option as a contracttype in SDKs, because all types that live in contracttypes must be convertible to ScVal via their ref form.
Close stellar/rs-soroban-env#444
Close stellar/rs-soroban-sdk#877