-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow use of Option in contracttype #444
Closed
sisuresh opened this issue
Sep 15, 2022
· 2 comments
· Fixed by stellar/rs-soroban-sdk#1145, stellar/rs-stellar-xdr#320 or #1198
Closed
Allow use of Option in contracttype #444
sisuresh opened this issue
Sep 15, 2022
· 2 comments
· Fixed by stellar/rs-soroban-sdk#1145, stellar/rs-stellar-xdr#320 or #1198
Comments
I believe this is done now, @leighmcculloch ? |
I'm not sure. Can you test it? If it works then we're good. |
This was referenced Nov 11, 2023
Merged
github-merge-queue bot
pushed a commit
that referenced
this issue
Nov 14, 2023
### What Update stellar-xdr. ### Why To get changes in stellar-xdr that fix Option<T> <> ScVal for: - Close stellar/rs-soroban-sdk#877 - Close #444 Dependent on: - stellar/rs-stellar-xdr#320
github-merge-queue bot
pushed a commit
to stellar/rs-soroban-sdk
that referenced
this issue
Nov 14, 2023
### What Try to make Option<T> work with contracttype ### Why Close stellar/rs-soroban-env#444 Close #877 Dependent on: - stellar/rs-stellar-xdr#320 - stellar/rs-soroban-env#1198
github-merge-queue bot
pushed a commit
to stellar/rs-soroban-sdk
that referenced
this issue
Nov 14, 2023
### What Try to make Option<T> work with contracttype ### Why Close stellar/rs-soroban-env#444 Close #877 Dependent on: - stellar/rs-stellar-xdr#320 - stellar/rs-soroban-env#1198
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What problem does your feature solve?
We should be able to include an
Option
member in acontracttype
. Limiting it toOption<RawVal>
should be fine because doing this generically might not be possible.The error if you try to use the following struct -
The text was updated successfully, but these errors were encountered: