Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximum Assertions? #139

Closed
nikmd23 opened this issue Nov 20, 2014 · 7 comments
Closed

Maximum Assertions? #139

nikmd23 opened this issue Nov 20, 2014 · 7 comments
Milestone

Comments

@nikmd23
Copy link

nikmd23 commented Nov 20, 2014

From readme.md:

The UI will warn you whenever the median value of your defined runs of a specific metric will go over the specified value...

I have a scenario where I only want to be warned if a value goes under the specified value.

For example:
phantomas

I screwed up my web server config and wasn't serving compressed assets. Now I am and want to make sure I don't mess it up again, so I set an assertion. Unfortunately, assertions only work in one direction.

How do I indication I want a warning if I have less than two compressed assets?

@stefanjudis
Copy link
Owner

@nikmd23 Hmm... Interesting. :)

Yeah might be possible quickly. Unfortunately I'm quite busy until next week.

Maybe you're interested in contributing, then I could point you in the right direction? :)

If not no problem. :)

@stefanjudis stefanjudis added this to the v0.11.0 milestone Nov 20, 2014
@nikmd23
Copy link
Author

nikmd23 commented Nov 20, 2014

No worries.

I'm also slammed with Thanksgiving (:us:) and prepping for a presentation at a big conference the following week. I'm going to be demoing grunt-phantomas in that presentation, but I'll just avoid this use case and show off everything else that can be done. :wink:

@stefanjudis
Copy link
Owner

Okay, now you got me. :)

When will you do the demo? And may I ask which conference?
It might be done until then. ;)

@nikmd23
Copy link
Author

nikmd23 commented Nov 21, 2014

Haha. That certainly wasn't my intent!

I'd need the demo to be ready by the 3rd of December. ;)

@stefanjudis
Copy link
Owner

Okay - let's do it. ;)

Can you maybe ping me in one week, when it's not done yet?
I'll planning to ship next minor version before 3rd of December then. :)

@nikmd23
Copy link
Author

nikmd23 commented Nov 21, 2014

Sure thing, sounds good to me. 😉

@stefanjudis
Copy link
Owner

screenshot 2014-11-29 23 14 32

I'd go with this - if it's fine. :)

stefanjudis added a commit that referenced this issue Nov 30, 2014
stefanjudis added a commit that referenced this issue Nov 30, 2014
stefanjudis added a commit that referenced this issue Nov 30, 2014
…ertions

added configurable assertions - fix #139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants