-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[STK-227] Pingdom support #55
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
df4f568
Use kubernetes interface
waseem-h c1f836f
Update Setup logic to use struct rather than adding more arguments
waseem-h ee85676
Refactor kubernetes client logic and enable out cluster config
waseem-h 44507cd
Remove extra binary
waseem-h eabb965
Update readme
waseem-h 305ed99
Update setup in readme
waseem-h fcad7ae
Add full pingdom implementation
waseem-h 76b3f20
Uncomment package
waseem-h 2974a06
Fix pingdom monitor url
waseem-h 538af83
Fix build directory
waseem-h File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
# Pingdom Configuration | ||
|
||
Currently additional pingdom configurations can be added through a set of annotations to each ingress object, the current supported annotations are: | ||
|
||
| Annotation | Description | | ||
|:--------------------------------------------------------:|:------------------------------------------------:| | ||
| monitor.stakater.com/pingdom/resolution | The pingdom check interval in minutes | | ||
| monitor.stakater.com/pingdom/send-notification-when-down | How many failed check attempts before notifying | | ||
| monitor.stakater.com/pingdom/paused | Set to "true" to pause checks | | ||
| monitor.stakater.com/pingdom/notify-when-back-up | Set to "false" to disable recovery notifications | |
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have this as a pingdom the only configuration? Surely this could be abstracted away and used between uptimerobot as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes you are correct, this should be done. Feel free to leave an issue or create a PR and we'll be welcome to add this change as soon as possible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drubin I've opened the issue here #69.