-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[STK-227] Pingdom support #55
Conversation
@waseem-h Image is available for testing. |
@@ -0,0 +1,78 @@ | |||
package main | |||
|
|||
// import "testing" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@waseem-h Why is this commented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cant run these tests in our pipeline. They require pingdom api key
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rasheedamir are we good to go with this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah we can't do anything!
@waseem-h Image is available for testing. |
|
||
| Annotation | Description | | ||
|:--------------------------------------------------------:|:------------------------------------------------:| | ||
| monitor.stakater.com/pingdom/resolution | The pingdom check interval in minutes | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have this as a pingdom the only configuration? Surely this could be abstracted away and used between uptimerobot as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes you are correct, this should be done. Feel free to leave an issue or create a PR and we'll be welcome to add this change as soon as possible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.