Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STK-227] Pingdom support #55

Merged
merged 10 commits into from
May 31, 2018
Merged

[STK-227] Pingdom support #55

merged 10 commits into from
May 31, 2018

Conversation

waseem-h
Copy link
Contributor

No description provided.

@waseem-h waseem-h self-assigned this May 30, 2018
@waseem-h waseem-h requested a review from hazim1093 May 30, 2018 04:29
@stakater-user
Copy link
Contributor

@waseem-h Yikes! You better fix it before anyone else finds out! Build 1 has Failed!

@stakater-user
Copy link
Contributor

@waseem-h Image is available for testing. docker pull stakater/ingressmonitorcontroller:PR-55-2

@rasheedamir rasheedamir mentioned this pull request May 30, 2018
@@ -0,0 +1,78 @@
package main

// import "testing"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@waseem-h Why is this commented?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cant run these tests in our pipeline. They require pingdom api key

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rasheedamir are we good to go with this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah we can't do anything!

@stakater-user
Copy link
Contributor

@waseem-h Image is available for testing. docker pull stakater/ingressmonitorcontroller:PR-55-3

@hazim1093 hazim1093 merged commit 1697cbc into master May 31, 2018
@hazim1093 hazim1093 deleted the pingdom-support branch May 31, 2018 08:18
@waseem-h waseem-h mentioned this pull request May 31, 2018

| Annotation | Description |
|:--------------------------------------------------------:|:------------------------------------------------:|
| monitor.stakater.com/pingdom/resolution | The pingdom check interval in minutes |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have this as a pingdom the only configuration? Surely this could be abstracted away and used between uptimerobot as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you are correct, this should be done. Feel free to leave an issue or create a PR and we'll be welcome to add this change as soon as possible

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drubin I've opened the issue here #69.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants