Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding kube-rbac-proxy resources for imc #388

Merged
merged 15 commits into from
Apr 12, 2023
Merged

Adding kube-rbac-proxy resources for imc #388

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
0274ed1
Adding kube-rbac-proxy resources for imc
Muneebstakater May 19, 2022
a533a5c
Adding values
Muneebstakater May 19, 2022
8e85808
Removing resources
Muneebstakater May 19, 2022
7627728
Adding values
Muneebstakater May 19, 2022
ce999e9
Adding resources on all containers
Muneebstakater May 19, 2022
365e99f
Adding resources on values.yaml
Muneebstakater May 19, 2022
f3f7359
Removing dashes
Muneebstakater May 19, 2022
81f0597
Removing dashes from end
Muneebstakater May 19, 2022
63156ba
Updating values.yaml to use single resources
Muneebstakater May 19, 2022
ddf5f39
Adding values in values.yaml
Muneebstakater May 20, 2022
011cef0
Removing resources
Muneebstakater May 20, 2022
c896071
Updating make file
Muneebstakater May 24, 2022
bda25cf
Commenting the fmt vet manifests
Muneebstakater May 24, 2022
ef9dee8
Updating make file and manifests
Muneebstakater May 24, 2022
67ccb9e
Merge branch 'master' into update-imc-resources
MuneebAijaz Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion charts/ingressmonitorcontroller/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ spec:
- containerPort: 8443
name: https
{{- end }}
resources:
{{- toYaml .Values.resources | nindent 10 }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if the rbac proxy resources are different from the manage container? plz refer to the Forecastle chart

- args:
- --health-probe-bind-address=:8081
- --metrics-bind-address=127.0.0.1:8080
Expand Down Expand Up @@ -89,4 +91,4 @@ spec:
tolerations:
{{- toYaml . | nindent 8 }}
{{- end }}
---
---
13 changes: 6 additions & 7 deletions charts/ingressmonitorcontroller/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,13 +48,12 @@ serviceAccount:
name: ""

resources:
{}
# limits:
# cpu: 100m
# memory: 128Mi
# requests:
# cpu: 100m
# memory: 128Mi
limits:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should remain empty. Comment it out as before.

cpu: 100m
memory: 128Mi
requests:
cpu: 100m
memory: 128Mi

podAnnotations: {}

Expand Down