-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding kube-rbac-proxy resources for imc #388
Conversation
@Muneebstakater Yikes! You better fix it before anyone else finds out! Build has Failed! |
@@ -59,6 +59,10 @@ spec: | |||
envFrom: | |||
{{- toYaml .Values.envFrom | nindent 8 }} | |||
{{- end }} | |||
{{- if .Values.resources }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plz add resources for kube-rbac-proxy container
@Muneebstakater Yikes! You better fix it before anyone else finds out! Build has Failed! |
@Muneebstakater Yikes! You better fix it before anyone else finds out! Build has Failed! |
@Muneebstakater Yikes! You better fix it before anyone else finds out! Build has Failed! |
@Muneebstakater Yikes! You better fix it before anyone else finds out! Build has Failed! |
@Muneebstakater Yikes! You better fix it before anyone else finds out! Build has Failed! |
@Muneebstakater Yikes! You better fix it before anyone else finds out! Build has Failed! |
@Muneebstakater Yikes! You better fix it before anyone else finds out! Build has Failed! |
@Muneebstakater Yikes! You better fix it before anyone else finds out! Build has Failed! |
@Muneebstakater Yikes! You better fix it before anyone else finds out! Build has Failed! |
# requests: | ||
# cpu: 100m | ||
# memory: 128Mi | ||
limits: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should remain empty. Comment it out as before.
@@ -41,6 +41,8 @@ spec: | |||
- containerPort: 8443 | |||
name: https | |||
{{- end }} | |||
resources: | |||
{{- toYaml .Values.resources | nindent 10 }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if the rbac proxy resources are different from the manage container? plz refer to the Forecastle chart
@Muneebstakater Yikes! You better fix it before anyone else finds out! Build has Failed! |
@Muneebstakater Yikes! You better fix it before anyone else finds out! Build has Failed! |
@Muneebstakater Yikes! You better fix it before anyone else finds out! Build has Failed! |
@Muneebstakater Yikes! You better fix it before anyone else finds out! Build has Failed! |
@stakater-user Yikes! You better fix it before anyone else finds out! Build has Failed! |
@MuneebAijaz Image is available for testing. |
No description provided.