Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding kube-rbac-proxy resources for imc #388

Merged
merged 15 commits into from
Apr 12, 2023
Merged

Conversation

Muneebstakater
Copy link
Contributor

No description provided.

@stakater-user
Copy link
Contributor

@Muneebstakater Yikes! You better fix it before anyone else finds out! Build has Failed!

@@ -59,6 +59,10 @@ spec:
envFrom:
{{- toYaml .Values.envFrom | nindent 8 }}
{{- end }}
{{- if .Values.resources }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plz add resources for kube-rbac-proxy container

@stakater-user
Copy link
Contributor

@Muneebstakater Yikes! You better fix it before anyone else finds out! Build has Failed!

@stakater-user
Copy link
Contributor

@Muneebstakater Yikes! You better fix it before anyone else finds out! Build has Failed!

@stakater-user
Copy link
Contributor

@Muneebstakater Yikes! You better fix it before anyone else finds out! Build has Failed!

@stakater-user
Copy link
Contributor

@Muneebstakater Yikes! You better fix it before anyone else finds out! Build has Failed!

@stakater-user
Copy link
Contributor

@Muneebstakater Yikes! You better fix it before anyone else finds out! Build has Failed!

@stakater-user
Copy link
Contributor

@Muneebstakater Yikes! You better fix it before anyone else finds out! Build has Failed!

@stakater-user
Copy link
Contributor

@Muneebstakater Yikes! You better fix it before anyone else finds out! Build has Failed!

@stakater-user
Copy link
Contributor

@Muneebstakater Yikes! You better fix it before anyone else finds out! Build has Failed!

@stakater-user
Copy link
Contributor

@Muneebstakater Yikes! You better fix it before anyone else finds out! Build has Failed!

# requests:
# cpu: 100m
# memory: 128Mi
limits:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should remain empty. Comment it out as before.

@@ -41,6 +41,8 @@ spec:
- containerPort: 8443
name: https
{{- end }}
resources:
{{- toYaml .Values.resources | nindent 10 }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if the rbac proxy resources are different from the manage container? plz refer to the Forecastle chart

@stakater-user
Copy link
Contributor

@Muneebstakater Yikes! You better fix it before anyone else finds out! Build has Failed!

@stakater-user
Copy link
Contributor

@Muneebstakater Yikes! You better fix it before anyone else finds out! Build has Failed!

@stakater-user
Copy link
Contributor

@Muneebstakater Yikes! You better fix it before anyone else finds out! Build has Failed!

@stakater-user
Copy link
Contributor

@Muneebstakater Yikes! You better fix it before anyone else finds out! Build has Failed!

@stakater-user stakater-user changed the title [dev:stage] Adding kube-rbac-proxy resources for imc Adding kube-rbac-proxy resources for imc May 31, 2022
@stakater-user
Copy link
Contributor

@stakater-user Yikes! You better fix it before anyone else finds out! Build has Failed!

@github-actions
Copy link

@MuneebAijaz Image is available for testing. docker pull stakater/ingressmonitorcontroller:SNAPSHOT-PR-388-67ccb9e5

@MuneebAijaz MuneebAijaz dismissed usamaahmadkhan’s stale review April 12, 2023 09:18

Tested PR, its working

@MuneebAijaz MuneebAijaz merged commit f505abf into master Apr 12, 2023
@usamaahmadkhan usamaahmadkhan deleted the update-imc-resources branch April 12, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants