Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Enable Prometheus metrics using statsd-exporter #128

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - Enable Prometheus metrics using statsd-exporter #128

wants to merge 3 commits into from

Conversation

siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented Feb 14, 2022 •
edited by adwk67
Loading

Description

Enable Prometheus metrics using statsd-exporter

Tested by stackabletech/integration-tests#150

Closes #95

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@siegfriedweber siegfriedweber requested a review from a team February 14, 2022 14:40
@siegfriedweber siegfriedweber self-assigned this Feb 14, 2022
@siegfriedweber siegfriedweber mentioned this pull request Feb 14, 2022
Merged
maltesander
maltesander previously requested changes Feb 15, 2022
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with integration tests and works. 2 minor things.

CHANGELOG.md Outdated Show resolved Hide resolved
rust/operator-binary/src/superset_controller.rs Outdated Show resolved Hide resolved
adwk67
adwk67 approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siegfriedweber
Copy link
Member Author

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 15, 2022

👎 Rejected by code reviews

@adwk67 adwk67 dismissed maltesander’s stale review February 15, 2022 11:15

Changes have all been implemented as requested.

@siegfriedweber
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Feb 15, 2022
@siegfriedweber
Enable Prometheus metrics using statsd-exporter (#128)
8f18f7e 
## Description

Enable Prometheus metrics using statsd-exporter

Tested by stackabletech/integration-tests#150

Closes #95
@bors
Copy link
Contributor

bors bot commented Feb 15, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Enable Prometheus metrics using statsd-exporter [Merged by Bors] - Enable Prometheus metrics using statsd-exporter Feb 15, 2022
@bors bors bot closed this Feb 15, 2022
@bors bors bot deleted the expose_metrics branch February 15, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander left review comments

@adwk67 adwk67 adwk67 approved these changes

Assignees

@siegfriedweber siegfriedweber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable Prometheus scraping
3 participants
@siegfriedweber @adwk67 @maltesander