Skip to content

Commit

Permalink
Remove unnecessary label containing the Prometheus port; Add BREAKING…
Browse files Browse the repository at this point in the history
… flag to the changelog
  • Loading branch information
siegfriedweber committed Feb 15, 2022
1 parent c5b2eca commit a4a4da5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
### Added

- Druid DB connections can now be configured in a custom resource ([#71]).
- Prometheus metrics enabled ([#128]).
- BREAKING: Prometheus metrics enabled ([#128]); The `statsdExporterVersion` must be set in the
cluster specification.

### Changed

Expand Down
1 change: 0 additions & 1 deletion rust/operator-binary/src/superset_controller.rs
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,6 @@ fn build_node_rolegroup_service(
statsd_exporter_version(superset).context(NoStatsdExporterVersionSnafu)?,
)
.with_label("prometheus.io/scrape", "true")
.with_label("prometheus.io/port", METRICS_PORT.to_string())
.build(),
spec: Some(ServiceSpec {
cluster_ip: Some("None".to_string()),
Expand Down

0 comments on commit a4a4da5

Please sign in to comment.