-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Correctly encode user given content, such as passwords #627
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice thanks! LGTM!
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM when tests pass!
As the product images have been build now started https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/nifi-operator-it-custom/57/console |
Tests passed first try 🚀 |
* fix: Correctly encode user given content, such as passwords * changelog * fix bcrypt problems * Update rust/operator-binary/src/security/authentication.rs Co-authored-by: Malte Sander <malte.sander.it@gmail.com> --------- Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
* fix: Correctly encode user given content, such as passwords (#627) * fix: Correctly encode user given content, such as passwords * changelog * fix bcrypt problems * Update rust/operator-binary/src/security/authentication.rs Co-authored-by: Malte Sander <malte.sander.it@gmail.com> --------- Co-authored-by: Malte Sander <malte.sander.it@gmail.com> * add vscode debugging profile * wip: add integration test for oidc * wip: debug oidc & jwts * wip * wip: map over ContainerBuilders * fix oidc test * fix oidc test * fix clippy, update CRD and remove debug files * run cargo fmt * address clippy and yamllint feedback * remove unneccessary return * reenable all tests * add docs and fix oidc test * remove reporting task from oidc test * add debug logging * fix test logging * use nifi-latest in oidc test * add comment why nifi-latest is used * clean up code and add comment * address feedback from review * improve oidc integration test * fix oidc test for nifi 2.0.0-M4 * increase timeout on test job creation * fix docs on oidc * move config for debugger to operator-templating * add comment to test job assert --------- Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de> Co-authored-by: Malte Sander <malte.sander.it@gmail.com> Co-authored-by: Nick Larsen <nick.larsen@stackable.tech>
Description
Fixes #624
Needs stackabletech/docker-images#706
Definition of Done Checklist
Author
Reviewer
Acceptance