Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correctly encode user given content, such as passwords #627

Merged
merged 6 commits into from
Jun 21, 2024

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Jun 11, 2024

Description

Fixes #624
Needs stackabletech/docker-images#706

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

@sbernauer sbernauer self-assigned this Jun 12, 2024
@sbernauer sbernauer marked this pull request as ready for review June 13, 2024 13:33
maltesander
maltesander previously approved these changes Jun 14, 2024
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice thanks! LGTM!

rust/operator-binary/src/security/authentication.rs Outdated Show resolved Hide resolved
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
@sbernauer sbernauer requested a review from maltesander June 14, 2024 12:21
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when tests pass!

@sbernauer
Copy link
Member Author

@sbernauer
Copy link
Member Author

Tests passed first try 🚀

@sbernauer sbernauer added this pull request to the merge queue Jun 21, 2024
Merged via the queue into main with commit f99b1ae Jun 21, 2024
32 checks passed
@sbernauer sbernauer deleted the fix/ldap-password-escaping branch June 21, 2024 12:22
labrenbe pushed a commit that referenced this pull request Jun 28, 2024
* fix: Correctly encode user given content, such as passwords

* changelog

* fix bcrypt problems

* Update rust/operator-binary/src/security/authentication.rs

Co-authored-by: Malte Sander <malte.sander.it@gmail.com>

---------

Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
github-merge-queue bot pushed a commit that referenced this pull request Aug 27, 2024
* fix: Correctly encode user given content, such as passwords (#627)

* fix: Correctly encode user given content, such as passwords

* changelog

* fix bcrypt problems

* Update rust/operator-binary/src/security/authentication.rs

Co-authored-by: Malte Sander <malte.sander.it@gmail.com>

---------

Co-authored-by: Malte Sander <malte.sander.it@gmail.com>

* add vscode debugging profile

* wip: add integration test for oidc

* wip: debug oidc & jwts

* wip

* wip: map over ContainerBuilders

* fix oidc test

* fix oidc test

* fix clippy, update CRD and remove debug files

* run cargo fmt

* address clippy and yamllint feedback

* remove unneccessary return

* reenable all tests

* add docs and fix oidc test

* remove reporting task from oidc test

* add debug logging

* fix test logging

* use nifi-latest in oidc test

* add comment why nifi-latest is used

* clean up code and add comment

* address feedback from review

* improve oidc integration test

* fix oidc test for nifi 2.0.0-M4

* increase timeout on test job creation

* fix docs on oidc

* move config for debugger to operator-templating

* add comment to test job assert

---------

Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Co-authored-by: Nick Larsen <nick.larsen@stackable.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Correctly encode user given content, such as passwords
3 participants