Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correctly encode user given content, such as passwords #571

Merged
merged 28 commits into from
Jul 10, 2024

Conversation

fhennig
Copy link
Contributor

@fhennig fhennig commented Jun 3, 2024

Description

fixes #219

Integration tests were successful: https://ci.stackable.tech/view/06%20Replicated/job/druid-operator-it-replicated/8/console

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

@fhennig fhennig self-assigned this Jun 3, 2024
rust/crd/src/lib.rs Outdated Show resolved Hide resolved
rust/crd/src/lib.rs Outdated Show resolved Hide resolved
rust/crd/src/lib.rs Outdated Show resolved Hide resolved
rust/crd/src/lib.rs Outdated Show resolved Hide resolved
@fhennig fhennig marked this pull request as ready for review June 4, 2024 12:43
@sbernauer sbernauer self-requested a review June 6, 2024 07:06
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also try to break the integration tests by setting as many weird characters in e.g. ldap bind credentials or internal passwords?

rust/crd/src/authentication/ldap.rs Outdated Show resolved Hide resolved
@fhennig
Copy link
Contributor Author

fhennig commented Jun 6, 2024

running a test 🤞

sbernauer
sbernauer previously approved these changes Jun 10, 2024
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM when tests pass

@sbernauer
Copy link
Member

Just a meta comment: product-utils is coming to an release soon-ish. I think it would make sense to use that tool everywhere for consistency reasons [and not rely on Druid features that might do thing slightly differently].

@labrenbe labrenbe mentioned this pull request Jun 14, 2024
@fhennig
Copy link
Contributor Author

fhennig commented Jun 19, 2024

You might be right there. I can also see an argument for using less parts, but maybe the consistency is better to have here. Happy to have other opinions, maybe @soenkeliebau

@sbernauer sbernauer assigned sbernauer and unassigned fhennig Jun 25, 2024
@sbernauer sbernauer changed the title replace sed usage with druid 'env' feature Correctly encode user given content, such as passwords Jun 25, 2024
@sbernauer sbernauer changed the title Correctly encode user given content, such as passwords fix: Correctly encode user given content, such as passwords Jun 25, 2024
labrenbe
labrenbe previously approved these changes Jun 26, 2024
@labrenbe labrenbe dismissed their stale review June 26, 2024 08:27

need to check again

@sbernauer sbernauer force-pushed the 219-replace-sed-with-env-feature branch from b09971e to 36f3169 Compare June 26, 2024 12:24
Copy link
Member

@labrenbe labrenbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fhennig fhennig added this pull request to the merge queue Jul 10, 2024
Merged via the queue into main with commit 95d27fa Jul 10, 2024
32 checks passed
@fhennig fhennig deleted the 219-replace-sed-with-env-feature branch July 10, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correctly encode user given content, such as passwords
3 participants