Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Filter Extension dependency from Aggregation Extension requests #716

Merged
merged 5 commits into from
Jun 25, 2024
Merged

Remove the Filter Extension dependency from Aggregation Extension requests #716

merged 5 commits into from
Jun 25, 2024

Conversation

jamesfisher-geo
Copy link
Contributor

@jamesfisher-geo jamesfisher-geo commented Jun 24, 2024

Related Issue(s):

Description:

  • Removes the Filter Extension depenency from AggregationExtensionPostRequest and AggregationExtensionGetRequest. This can be done in the implementations.
  • Improve the aggregations typing.

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the CHANGELOG.

Copy link
Member

@vincentsarago vincentsarago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the aggregate extension should depends on Search.

Users wil create the Search model using search_get_request_model by providing BaseSearchGetRequest and the list of extension they want to support

@jamesfisher-geo
Copy link
Contributor Author

I don't think the aggregate extension should depends on Search.

Users wil create the Search model using search_get_request_model by providing BaseSearchGetRequest and the list of extension they want to support

Okay. Does the aggregation extension spec need to be updated to reflect this? The spec has the same fields as search with the addition of aggregations

@vincentsarago
Copy link
Member

oh I see 🤦 that's my bad then.

it seems that the aggregate extension should depends on the search classes.

BUT the aggregate extension shouldn't influence the /search options

@vincentsarago vincentsarago merged commit f311dc6 into stac-utils:main Jun 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants