-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the Filter Extension dependency from Aggregation Extension requests #716
Remove the Filter Extension dependency from Aggregation Extension requests #716
Conversation
stac_fastapi/extensions/stac_fastapi/extensions/core/aggregation/request.py
Show resolved
Hide resolved
stac_fastapi/extensions/stac_fastapi/extensions/core/aggregation/request.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the aggregate extension should depends on Search.
Users wil create the Search model using search_get_request_model
by providing BaseSearchGetRequest
and the list of extension they want to support
Okay. Does the aggregation extension spec need to be updated to reflect this? The spec has the same fields as search with the addition of |
oh I see 🤦 that's my bad then. it seems that the aggregate extension should depends on the search classes. BUT the aggregate extension shouldn't influence the |
Related Issue(s):
Description:
AggregationExtensionPostRequest
andAggregationExtensionGetRequest
. This can be done in the implementations.aggregations
typing.PR Checklist:
pre-commit
hooks pass locallymake test
)make docs
)