Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency between Aggregate and Filter extensions #715

Closed
vincentsarago opened this issue Jun 24, 2024 · 2 comments
Closed

Remove dependency between Aggregate and Filter extensions #715

vincentsarago opened this issue Jun 24, 2024 · 2 comments

Comments

@vincentsarago
Copy link
Member

vincentsarago commented Jun 24, 2024

@jamesfisher-gis sorry I'm just realizing this now but I don't think we should do this, at least I don't see in the aggregate extension why the filter attributes should be enabled with the aggregations ones.

I think it will be up to the implementers to add the filter extension and also handle them in the client.

Originally posted by @vincentsarago in #684 (comment)

@vincentsarago
Copy link
Member Author

aggregations: Optional[Union[str, List[str]]] = attr.ib(default=None)

also realizing that in ☝️ we use attr.ib instead of pydantic.Field

@jamesfisher-geo
Copy link
Contributor

Hey. That makes sense.

I have a couple other small bug fixes for aggregation. I will submit a PR today that removes the Filter extension dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants