Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow url encoded queries #504

Merged
merged 2 commits into from
Nov 29, 2022
Merged

Allow url encoded queries #504

merged 2 commits into from
Nov 29, 2022

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Nov 28, 2022 •
edited
Loading

Related Issue(s):

Description:

Currently query in GET requests does not support url-encoded values. This fixes for both backends.

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the CHANGELOG.

@gadomski gadomski mentioned this pull request Nov 28, 2022
Merged
3 tasks
geospatial-jeff
geospatial-jeff approved these changes Nov 29, 2022
View reviewed changes
Copy link
Collaborator

@geospatial-jeff geospatial-jeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Surprised this hasn't been noticed before.

@geospatial-jeff geospatial-jeff merged commit 97b0911 into master Nov 29, 2022
@gadomski gadomski deleted the url-encoded-query branch November 29, 2022 13:12
@gadomski gadomski added this to the 2.4.4 milestone Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geospatial-jeff geospatial-jeff geospatial-jeff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4.4
Development

Successfully merging this pull request may close these issues.
2 participants
@gadomski @geospatial-jeff