-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix query
in GET requests
#362
Conversation
The query value should be url encoded, so it's a bug if stac-fastapi isn't handling that correctly. |
b8f0b27
to
7972ba7
Compare
I've opened stac-utils/stac-fastapi#504 to fix, and added url encoding to this PR. However, this means that tests will be broken until the Planetary Computer picks up stac-utils/stac-fastapi#504. I think it's worth waiting to merge this PR until the Planetary Computer is fixed, since this isn't a critical fix. |
Agree with waiting -- I only found it because I had a get endpoint that was proxying through a stac api request, and I just wanted to pass the parameters through to pystac-client needing to parse them, but that was easy enough to do. |
Codecov ReportBase: 85.05% // Head: 85.12% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #362 +/- ##
==========================================
+ Coverage 85.05% 85.12% +0.07%
==========================================
Files 11 11
Lines 823 827 +4
==========================================
+ Hits 700 704 +4
Misses 123 123
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
375b97c
to
202be62
Compare
Okay, I'm marking this ready to review. Even if the Planetary Computer doesn't support quoted dictionaries in GET requests, users can always use POST. |
2015e2a
to
7591170
Compare
7591170
to
67c0f66
Compare
Related Issue(s):
Description:
Fixes
query
in GET requests by stringifying the JSON dictionary. Note that (for the Planetary Computer at least) the query parameter cannot be url encoded. @philvarner do you think this is a server bug? If so I can open it on stac-fastapi.PR Checklist: