-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update get_item in sqlalchemy backend #275
Conversation
I've also been running into this problem with stac-fastapi currently requiring Item IDs to be unique across the whole database, rather than just within a collection. On top of this change, I think for the SQLAlchemy backend we would need to update I've tested this with creating two items with the same ID but in different collections, using the SQLAlchemy backend - and with these additions it works fine. I can't seem to push to this PR, so I've added the relevant code below: Add stac_fastapi\sqlalchemy\alembic\versions\821aa04011e8_change_pri_key_for_item.py:
stac_fastapi\sqlalchemy\stac_fastapi\sqlalchemy\models\database.py:
|
@robintw Hi. Great feedback. Can you fork my branch and push to it? I'm not a git expert or anything. |
@jonhealy1 Yup, I'll do that later today. |
These changes LGTM, waiting on @jonhealy1 to merge @robintw PR into the branch of this PR, at which point all this should need is a changelog entry |
@lossyrob Ok done |
Related Issue(s): #186
Description:
Update get_item in sqlalchemy backend to allow for querying for items with same ids but in different collections. Add test.
PR Checklist:
pre-commit run --all-files
)make test
)make docs
)