Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Items are not uniquely identified by their collection #186

Closed
orilevari opened this issue Jul 14, 2021 · 2 comments
Closed

Items are not uniquely identified by their collection #186

orilevari opened this issue Jul 14, 2021 · 2 comments

Comments

@orilevari
Copy link

From my understanding, this repo defines an Item's primary key as only its id field, not the collection it belongs to. This restricts items with the same id from being inserted into multiple different collections. However, according to the stac spec here (https://github.com/radiantearth/stac-spec/blob/master/item-spec/item-spec.md#id), the id field only needs to be unique within their own collections, not globally.

Is this an intentional break from the stac specification? If not, can the Item implementation be changed to support the same id in different collections?

@robintw
Copy link
Contributor

robintw commented Oct 20, 2021

I think this is now fixed by #275 @orilevari.

@orilevari
Copy link
Author

thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants