Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pom.xml depend on the JVM artifact #1125

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

swankjesse
Copy link
Collaborator

This should prevent Maven users from needing to change
their dependencies from okio to okio-jvm. More importantly,
it should also prevent them from inadvertently getting two
different Okio JVM artifacts on their classpaths at once.

This should prevent Maven users from needing to change
their dependencies from okio to okio-jvm. More importantly,
it should also prevent them from inadvertently getting two
different Okio JVM artifacts on their classpaths at once.
@swankjesse
Copy link
Collaborator Author

We end up with this:

<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
  <!-- This module was also published with a richer model, Gradle metadata,  -->
  <!-- which should be used instead. Do not delete the following line which  -->
  <!-- is to indicate to Gradle or any Gradle module metadata file consumer  -->
  <!-- that they should prefer consuming it instead. -->
  <!-- do_not_remove: published-with-gradle-metadata -->
  <modelVersion>4.0.0</modelVersion>
  <groupId>com.squareup.okio</groupId>
  <artifactId>okio</artifactId>
  <version>3.1.0</version>
  <name>okio</name>
  <description>A modern I/O API for Java</description>
  <url>https://github.com/square/okio/</url>
  <licenses>
    <license>
      <name>The Apache Software License, Version 2.0</name>
      <url>http://www.apache.org/licenses/LICENSE-2.0.txt</url>
      <distribution>repo</distribution>
    </license>
  </licenses>
  <developers>
    <developer>
      <id>square</id>
      <name>Square, Inc.</name>
    </developer>
  </developers>
  <scm>
    <connection>scm:git:git://github.com/square/okio.git</connection>
    <developerConnection>scm:git:ssh://git@github.com/square/okio.git</developerConnection>
    <url>https://github.com/square/okio/</url>
  </scm>
  <dependencies>
    <dependency>
      <groupId>com.squareup.okio</groupId>
      <artifactId>okio-jvm</artifactId>
      <version>3.1.0</version>
      <scope>compile</scope>
    </dependency>
  </dependencies>
</project>

@swankjesse
Copy link
Collaborator Author

🎉 I tested this manually with a Maven project and it worked as expected.

@swankjesse swankjesse merged commit 73c08ca into master Jun 27, 2022
@swankjesse swankjesse deleted the jwilson.0626.depend_on_jvm branch June 27, 2022 02:16
gesellix added a commit to docker-client/docker-filesocket that referenced this pull request Jul 11, 2023
gesellix added a commit to docker-client/docker-filesocket that referenced this pull request Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants