Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add okio-jvm to the okio-bom #1121

Closed
rickie opened this issue Jun 20, 2022 · 4 comments · Fixed by #1269
Closed

Add okio-jvm to the okio-bom #1121

rickie opened this issue Jun 20, 2022 · 4 comments · Fixed by #1269

Comments

@rickie
Copy link

rickie commented Jun 20, 2022

We are working on the upgrade of okio and decided to use the okio-bom.
As we are using Maven, we also had to switch to okio-jvm (see related issue #1067).

However, now that we switched to the BOM, we also had to specify the okio-jvm dependency to make sure it uses the same version as in the okio-bom.
Would it be possible to add the okio-jvm in the okio-bom such that the dependency is provided "out of the box"?

@bogdandrutu
Copy link

Can this be fixed please?

@Egorand
Copy link
Collaborator

Egorand commented Apr 25, 2023

If I understand correctly, with #1125 there's no need for Maven users to depend on okio-jvm anymore? @bogdandrutu can you try depending on the latest version of okio (instead of okio-jvm) in your project and see if that works?

@Stephan202
Copy link

Hey @Egorand! This issue is still relevant for users of the maven-dependency-plugin, as explicit references to a dependency require said dependency to be declared explicitly:

[INFO] --- dependency:3.5.0:analyze-only (analyze-dependencies) @ messaging-support ---
[ERROR] Used undeclared dependencies found:
[ERROR]    com.squareup.okio:okio-jvm:jar:3.3.0:runtime

So it'd be nice if okio-jvm can be added to okio-bom 🙏

rickie added a commit to rickie/okio that referenced this issue May 1, 2023
rickie added a commit to rickie/okio that referenced this issue May 1, 2023
@rickie
Copy link
Author

rickie commented May 1, 2023

I filed: #1256.

swankjesse pushed a commit that referenced this issue Jun 18, 2023
swankjesse pushed a commit that referenced this issue Jun 18, 2023
* Collect BOM constraints automatically

Closes: #1121

* Publish assetfilesystem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants