This repository has been archived by the owner on Aug 24, 2022. It is now read-only.
Refresh: Dynamic on JS side #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use JS-side callsite/binders analogs. Updated ILSpy version.
CallSiteVariablesEliminated test deleted. VerbatimDynamic test moved to FailingTests class.
…ories list in assembly resolver Fix threading issues with AssemblyResolver
|
Do you mind filing a bookkeeping (edit: issue) for me to follow up and update the examples? (As-is they'll be fine because Try is running a build I prepare manually, so that it doesn't break every time I commit.) |
|
|
Fixed all build problems. TravisCI still reports as broken due Mozilla problem (#956). |
|
Please wait a little bit before merging, looks like I found some small issues. |
|
Everything is OK, could be merged. |
|
Thanks a lot for the hard work on this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is refreshed version of #925 and #935. It also includes #957 and ILSpy updated to latest version. Please use this one instead of other three (I've closed them).
With merging this Roslyn-compiled sources should work good. This PR is "breaking change", as it changes JS-interop results to object from dynamic (but they could be casted to dynamic and still work as before).