This repository has been archived by the owner on Aug 24, 2022. It is now read-only.
JS-interop functions return object #935
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use JS-side callsite/binders analogs. Updated ILSpy version.
CallSiteVariablesEliminated test deleted. VerbatimDynamic test moved to FailingTests class.
|
What did you update the submodules to point to? |
|
With latest commit from sq/JSIL.Meta NoDynamic branch (b185a3d1a30e6d580456e6d78eaf07f0b06a13bb) |
|
As long as it's not pointing towards JSIL.Meta master, can you also merge this into a branch on sq/JSIL? I want to switch all the master branches over wholesale at once. |
|
Sure. Will push it to branch NoDynamic. |
|
Done. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is next part for #925 (and include that PR).
JS-interop return object instead of dynamic now.
Probably we need update samples used for TryJSIL, but I don't know where they are located.