Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Fixes due to the new Pytest 4 #8259

Merged
merged 7 commits into from
Nov 17, 2018
Merged

PR: Fixes due to the new Pytest 4 #8259

merged 7 commits into from
Nov 17, 2018

Conversation

ccordoba12
Copy link
Member

@spyder-ide/core-developers, please take a look at this PR. Now we can't call fixtures as functions so we have to pass parameters to them with parametrize.

@ccordoba12 ccordoba12 added this to the v3.3.2 milestone Nov 16, 2018
@pep8speaks
Copy link

pep8speaks commented Nov 16, 2018 •
edited
Loading

Hello @ccordoba12! Thanks for updating the PR.

Line 505:80: E501 line too long (83 > 79 characters)
Line 523:80: E501 line too long (80 > 79 characters)

Line 484:80: E501 line too long (88 > 79 characters)

Line 69:80: E501 line too long (86 > 79 characters)

Line 19:80: E501 line too long (90 > 79 characters)

Comment last updated on November 17, 2018 at 02:57 Hours UTC

@ccordoba12 ccordoba12 changed the title PR: Several fixes due to the new Pytest 4 PR: Fixes due to the new Pytest 4 Nov 16, 2018
@ccordoba12 ccordoba12 merged commit bd73f88 into spyder-ide:3.x Nov 17, 2018
@ccordoba12 ccordoba12 deleted the fix-pytest-4 branch November 17, 2018 03:36
ccordoba12 added a commit that referenced this pull request Nov 17, 2018
@ccordoba12
Merge from 3.x: PR #8259
33c56b1 
This also merges some translations from 3.x and PR #8249
ccordoba12 added a commit that referenced this pull request Nov 17, 2018
@ccordoba12
Merge from 3.x
e254fc3 
PR #8261
PR #8259
PR #8255
PR #8249
PR #8248
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.3.2
Development

Successfully merging this pull request may close these issues.
2 participants
@ccordoba12 @pep8speaks