Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Prevent an error during the initialization of the Editor plugin #8249

Merged
merged 1 commit into from
Nov 15, 2018

Conversation

jnsebgosselin
Copy link
Member

@jnsebgosselin jnsebgosselin commented Nov 15, 2018

Description of Changes

This was introduced in PR #8116

Some plugin variables need to be defined before the call to self.initialize_plugin() to prevent this error from happening.

Issue(s) Resolved

Fixes #8216

Developer Certificate of Origin Affirmation

By submitting this Pull Request or typing my name below, I affirm the
Developer Certificate of Origin
with respect to both the content of the contribution itself and this post,
and understand I am releasing it under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: Jean-Sébastien Gosselin

@pep8speaks
Copy link

Hello @jnsebgosselin! Thanks for submitting the PR.

@ccordoba12 ccordoba12 added this to the v3.3.2 milestone Nov 15, 2018
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jnsebgosselin!

@ccordoba12 ccordoba12 merged commit 3129fa5 into spyder-ide:3.x Nov 15, 2018
ccordoba12 added a commit that referenced this pull request Nov 17, 2018
This also merges some translations from 3.x and PR #8249
ccordoba12 added a commit that referenced this pull request Nov 17, 2018
@jnsebgosselin jnsebgosselin deleted the fix_editor_init branch January 5, 2019 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants