Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Don't ignore all files when exclude pattern is empty #7816

Merged
merged 3 commits into from
Sep 3, 2018
Merged

PR: Don't ignore all files when exclude pattern is empty #7816

merged 3 commits into from
Sep 3, 2018

Conversation

ehabkost
Copy link
Contributor

@ehabkost ehabkost commented Sep 2, 2018

Pull Request Checklist

  • Read and followed this repo's Contributing Guidelines
  • Based your PR on the latest version of the correct branch (master or 3.x)
  • Followed PEP8 for code style
  • Ensured your pull request hasn't eliminated unrelated blank lines/spaces,
    modified the spyder/defaults directory, or added new icons/assets
  • Wrote at least one-line docstrings for any new functions
  • Added at least one unit test covering the changes, if at all possible
  • Described your changes and the motivation for them below
  • Noted what issue(s) this pull request resolves, creating one if needed
  • Included a screenshot, if this PR makes any visible changes to the UI

Description of Changes

This addresses issue #7811, making findinfiles not ignore all files if the exclude pattern is empty.

Issue(s) Resolved

Fixes #7811

@ehabkost
findinfiles: Translate exclude pattern before validation
f64a1e5 
Move the code that translates a exclude pattern outside the block
that that validates the pattern.

This way the code is easier to follow, with the translation and
validation steps clearly separated from each other.
@ehabkost
findinfiles: Ignore exclude regexp if it's empty
d1f925d 
If the exclude regexp is empty, don't try to compile it. Change
SearchThread so an empty string will make no file be excluded
from the search.

This fixes issue spyder-ide#7811 when exclude_re is true.

Signed-off-by: Eduardo Habkost <ehabkost@raisama.net>
@ehabkost
findinfiles: Skip empty strings when building file pattern regexp
a10a893 
When building the regexp for file patterns when exclude_re is
false, skip empty strings.

This fixes issue spyder-ide#7811 when exclude_re is false.
ccordoba12
ccordoba12 approved these changes Sep 3, 2018
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @ehabkost!

@ccordoba12 ccordoba12 added this to the v3.3.2 milestone Sep 3, 2018
@ccordoba12 ccordoba12 changed the title Don't ignore all files when exclude pattern is empty PR: Don't ignore all files when exclude pattern is empty Sep 3, 2018
@ccordoba12 ccordoba12 merged commit 41f3cf3 into spyder-ide:3.x Sep 3, 2018
ccordoba12 added a commit that referenced this pull request Sep 3, 2018
@ccordoba12
Merge from 3.x: PR #7816
7f8cc71 
Fixes #7811
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.3.2
Development

Successfully merging this pull request may close these issues.
2 participants
@ehabkost @ccordoba12