Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find In Files: empty "Exclude" field makes all files be excluded #7811

Closed
ehabkost opened this issue Sep 1, 2018 · 0 comments
Closed

Find In Files: empty "Exclude" field makes all files be excluded #7811

ehabkost opened this issue Sep 1, 2018 · 0 comments
Labels
component:Find in files type:Bug
Milestone
v3.3.2

Comments

@ehabkost
Copy link
Contributor

ehabkost commented Sep 1, 2018

When the "exclude" field on Find In Files is empty, all files seem to be excluded from the search, and the search returns no matches.

I'm running the latest version of the 3.x branch, commit 0d6686e.
@ccordoba12 ccordoba12 added this to the v3.3.2 milestone Sep 1, 2018
ehabkost added a commit to ehabkost/spyder that referenced this issue Sep 2, 2018
@ehabkost
findinfiles: Ignore exclude regexp if it's empty
dd9dae9 
If the exclude regexp is empty, don't try to compile it. Change
SearchThread so an empty string will make no file be excluded
from the search.

This fixes issue spyder-ide#7811 when exclude_re is true.

Signed-off-by: Eduardo Habkost <ehabkost@raisama.net>
ehabkost added a commit to ehabkost/spyder that referenced this issue Sep 2, 2018
@ehabkost
findinfiles: Skip empty strings when building file pattern regexp
0920548 
When building the regexp for file patterns when exclude_re is
false, skip empty strings.

This fixes issue spyder-ide#7811 when exclude_re is false.
ehabkost added a commit to ehabkost/spyder that referenced this issue Sep 2, 2018
@ehabkost
findinfiles: Ignore exclude regexp if it's empty
bf6de4a 
If the exclude regexp is empty, don't try to compile it. Change
SearchThread so an empty string will make no file be excluded
from the search.

This fixes issue spyder-ide#7811 when exclude_re is true.

Signed-off-by: Eduardo Habkost <ehabkost@raisama.net>
ehabkost added a commit to ehabkost/spyder that referenced this issue Sep 2, 2018
@ehabkost
findinfiles: Skip empty strings when building file pattern regexp
17e3d21 
When building the regexp for file patterns when exclude_re is
false, skip empty strings.

This fixes issue spyder-ide#7811 when exclude_re is false.
@ehabkost ehabkost mentioned this issue Sep 2, 2018
Closed
9 tasks
ehabkost added a commit to ehabkost/spyder that referenced this issue Sep 2, 2018
@ehabkost
findinfiles: Ignore exclude regexp if it's empty
d1f925d 
If the exclude regexp is empty, don't try to compile it. Change
SearchThread so an empty string will make no file be excluded
from the search.

This fixes issue spyder-ide#7811 when exclude_re is true.

Signed-off-by: Eduardo Habkost <ehabkost@raisama.net>
ehabkost added a commit to ehabkost/spyder that referenced this issue Sep 2, 2018
@ehabkost
findinfiles: Skip empty strings when building file pattern regexp
a10a893 
When building the regexp for file patterns when exclude_re is
false, skip empty strings.

This fixes issue spyder-ide#7811 when exclude_re is false.
@ehabkost ehabkost mentioned this issue Sep 2, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:Find in files type:Bug
Projects
None yet
Milestone
v3.3.2
Development

No branches or pull requests
2 participants
@ehabkost @ccordoba12