Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Change pep8 check_executable for pycodestyle. #5792

Merged
merged 2 commits into from
Nov 19, 2017

Conversation

dalthviz
Copy link
Member

Fixes #5791


Thanks to @CAM-Gerlach for pointing this out 👍

@dalthviz dalthviz added this to the v3.2.5 milestone Nov 19, 2017
@dalthviz dalthviz self-assigned this Nov 19, 2017
@dalthviz dalthviz requested a review from ccordoba12 November 19, 2017 04:15
@pep8speaks
Copy link

pep8speaks commented Nov 19, 2017

Hello @dalthviz! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on November 19, 2017 at 04:23 Hours UTC

@CAM-Gerlach
Copy link
Member

I see pep8 doesn't take too kindly to being replaced, haha...

Thanks for doing up the PR, @dalthviz . I wasn't sure if @ccordoba12 had direct push access to the repo and could thus just commit it directly, or if there was anything else silly I was missing, otherwise I wouldn't have wanted to waste your time actually doing the work for me...gotta make that big first PR sometime, and you can't start much smaller than this, heh.

@dalthviz
Copy link
Member Author

No problem @CAM-Gerlach, if it fixes something it has value 👍 (even if it's something that only needs the change of a line). Also, normally we always do a PR, we never push directly to any branch (you could say this is kind of a standard practice for us). Furthermore, all the help you can give us is really appreciated! so if you want to do some fixes let us know :) . Basically just open a PR taking as base the branch where the problem is showing (3.x if is a bug present in 3.2.x and master, or master for bugs only present there).

@CAM-Gerlach
Copy link
Member

Thanks ^_^. I feel bad submitting all these long and detailed issues and not actually pitching in to help; I've never done GUI/Qt anything so there's a lot to figure out there, and I'm not even anywhere near being a Python whiz, coming from a heavy R background. However, I've been working at it and actually was putting the finishing touches on a PR for my own issue when #5771 beat me to it. However, despite my n00bness my solution was essentially line for line what was in the PR, so that was a pretty encouraging start. Looking at some Community:Easy things right now, maybe starting with #5770 , and we'll see where it goes...I have quite a few different research and final projects on my plate at the moment as a grad student. In the meantime, I'm trying to do my part triaging and responding to the many issues reported here, most non-Spyder related it seems or lacking the information necessary to act on them. Cheers!

@ccordoba12
Copy link
Member

Thanks @CAM-Gerlach for your wanting to help us! As you said, it's a lot of work to respond to all the reported issues here.

@ccordoba12 ccordoba12 merged commit 40dcf07 into spyder-ide:3.x Nov 19, 2017
ccordoba12 added a commit that referenced this pull request Nov 19, 2017
@CAM-Gerlach
Copy link
Member

Its the least I can do, @ccordoba12 ; the more regular folks like me can help deal with the perpetual daily grind of (mostly user-specific or non-Spyder) issues, writing/improving docs and (hopefully soon) simple PRs, the more time folks like you and @dalthviz have to build the really awesome stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants