PR: Make arrow-key selection in completion widget "roll over" #5771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If up arrow and already at the top, go at the last item. - If down arrow and already at bottom, go at the first item.
goanpeca
reviewed
Nov 16, 2017
spyder/widgets/sourcecode/base.py
Outdated
| @@ -174,7 +174,12 @@ def keyPressEvent(self, event): | |||
| elif key in (Qt.Key_Up, Qt.Key_Down, Qt.Key_PageUp, Qt.Key_PageDown, | |||
| Qt.Key_Home, Qt.Key_End, | |||
| Qt.Key_CapsLock) and not modifier: | |||
| QListWidget.keyPressEvent(self, event) | |||
| if key == Qt.Key_Up and self.currentRow() == 0: | |||
| self.setCurrentRow(self.count()-1) | |||
There was a problem hiding this comment.
self.setCurrentRow(self.count() - 1) (spaces :-p)
goanpeca
approved these changes
Nov 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5763
What this does:
CompletionWidgetand the Up arrow key is clicked while already at the top of the list, go to the bottom of the list.CompletionWidgetand the Down arrow key is clicked while already at the bottom of the list, return at the top of the list.