PR: Don't show internet conection errors on startup when trying to check for new releases #4237
Conversation
…for new releases.
spyder/workers/updates.py
Outdated
| self.error = error_msg | ||
| self.sig_ready.emit() | ||
| # Don't show dialog when starting up spyder and an error occur | ||
| if not self.startup or error_msg is None: |
There was a problem hiding this comment.
Shouldn't this be ... or error_msg is not None?
There was a problem hiding this comment.
Hmm no, the idea is not to show the dialog when there is an error:
Maybe it will be easy to understand:
if not (self.startup and error_message is not None):
Or
if self.startup and error_message is not None: return
There was a problem hiding this comment.
Hmm no, the idea is not to show the dialog when there is an error
I don't agree. The idea (for me) is to not show the dialog if there are errors but only at startup (because it's very annoying). However, if you want to manually check for updates, Spyder should an error message in case it can't do it.
There was a problem hiding this comment.
Yes, that's the idea, the expression will evaluate True when startup is False (regardless if error_message is None or not)
There was a problem hiding this comment.
Ok, but if error_msg is different from None, we also want to show the dialog. And that's not the case here because we enter this block if error_msg is None (which is a contradiction for me and what motivated me to write my first comment).
spyder/workers/updates.py
Outdated
| self.error = error_msg | ||
| self.sig_ready.emit() | ||
| # Don't show dialog when starting up spyder and an error occur | ||
| if not (self.startup and error_message is not None): |
8b6e2ca to
eec7503
Compare
Fixes #4217