PR: Remove logic to delete last dir separator (\, /) in find and replace widget #3699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
reviewed
Nov 22, 2016
| @@ -114,9 +114,6 @@ def set_current_text(self, text): | |||
| def add_current_text(self): | |||
| """Add current text to combo box history (convenient method)""" | |||
| text = self.currentText() | |||
| if osp.isdir(text): | |||
| if text[-1] == os.sep: | |||
| text = text[:-1] | |||
There was a problem hiding this comment.
I think this was added by @goanpeca as a little convenience for the Working Directory toolbar. So removing these lines from BaseComboBox is fine.
But (as part of this PR) please also redefine the add_current_text method of PathComboBox (which is some lines below this) to be exactly the same as it was here (PathComboBox is the combobox used in the Working Directory).
818725c to
cb90ce6
Compare
|
Thanks @rlaverde, merging now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3141