Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search for backslash (\) sign #3141

Closed
Winand opened this issue Apr 28, 2016 · 5 comments
Closed

Search for backslash (\) sign #3141

Winand opened this issue Apr 28, 2016 · 5 comments

Comments

@Winand
Copy link

Winand commented Apr 28, 2016

WinPython-32bit-3.4.4.2

When searching for a line continuation sign () it disappears from the find textbox when I try to go to the next result. Going backwards works fine.

@Winand
Copy link
Author

Winand commented Apr 29, 2016

The problem is within add_current_text function, which is called in keyPressEvent and find_next:

#\widgets\comboboxes.py:114
def add_current_text(self):
    """Add current text to combo box history (convenient method)"""
    text = self.currentText()
    if osp.isdir(text):
        if text[-1] == os.sep:
            text = text[:-1]
    self.add_text(text)

Maybe this can fix it? if text[-1] == os.sep and len(text)>1:

@ccordoba12 ccordoba12 modified the milestones: v3.0beta4, v3.1 May 14, 2016
@ccordoba12
Copy link
Member

Thanks for looking into this one. I'll try to fix it for Spyder 3.0 beta4 :-)

@ccordoba12 ccordoba12 modified the milestones: v3.1, v3.0beta4 Jun 9, 2016
@Nodd
Copy link
Contributor

Nodd commented Jun 11, 2016

I think we should completely remove the magic here, since it doesn't work in every case. If the user wants to search for a filename without a backslash at the end, he can remove it himself.

@ccordoba12
Copy link
Member

@rlaverde, please work on this one.

@rlaverde
Copy link
Member

Should all the "magic" be removed, or just add a condition to avoid removing "" or "/"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants