Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve github issue template #2411

Merged
merged 2 commits into from
May 7, 2015
Merged

Improve github issue template #2411

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e9fb71
Improve github issue template
Nodd May 6, 2015
d5d16bd
Remove unneeded global declarations
Nodd May 6, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions spyderlib/dependencies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ def add(modname, features, required_version, installed_version=None):

def check(modname):
"""Check if required dependency is installed"""
global DEPENDENCIES
for dependency in DEPENDENCIES:
if dependency.modname == modname:
return dependency.check()
Expand All @@ -80,7 +79,6 @@ def check(modname):

def status():
"""Return a complete status of Optional Dependencies"""
global DEPENDENCIES
maxwidth = 0
col1 = []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why removing these two references to DEPENDENCIES as part of this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because at first I wanted to use a list for the dependencies so I looked how dependencies.status() was coded. This is a simple change to clean up the codebase a bit so I included it anyway. global is needed only when defining new variables, not when using them.

col2 = []
Expand Down
22 changes: 12 additions & 10 deletions spyderlib/spyder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2332,26 +2332,28 @@ def report_issue(self):
issue_template = """\
## Description

* *What steps will reproduce the problem?*
1.
2.
3.
**What steps will reproduce the problem?**

* *What is the expected output? What do you see instead?*
1.
2.
3.

**What is the expected output? What do you see instead?**

* *Please provide any additional information below*

**Please provide any additional information below**


## Version and main components

* Spyder Version: %s %s
* Python Version: %s
* Qt Version : %s, %s %s on %s
* Spyder Version: %s %s
* Python Version: %s
* Qt Versions: %s, %s %s on %s

## Optional dependencies

```
%s
```
""" % (versions['spyder'],
revision,
versions['python'],
Expand Down