Improve github issue template #2411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -80,7 +79,6 @@ def check(modname): | |||
|
|
|||
| def status(): | |||
| """Return a complete status of Optional Dependencies""" | |||
| global DEPENDENCIES | |||
There was a problem hiding this comment.
Why removing these two references to DEPENDENCIES as part of this PR?
There was a problem hiding this comment.
Because at first I wanted to use a list for the dependencies so I looked how dependencies.status() was coded. This is a simple change to clean up the codebase a bit so I included it anyway. global is needed only when defining new variables, not when using them.
|
Thanks! Things look much better with your improvements :-) |
ccordoba12
added a commit
that referenced
this pull request
May 7, 2015
Improve github issue template
ccordoba12
added a commit
that referenced
this pull request
Jun 8, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Templates for issues in github had a few problems: