Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SpanFilter #1037

Closed
wants to merge 2 commits into from
Closed

Added SpanFilter #1037

wants to merge 2 commits into from

Conversation

marcingrzejszczak
Copy link
Contributor

without this change we cannot filter out spans to be sent to Zipkin
with this change we give users a hook to achieve that

fixes gh-1033

without this change we cannot filter out spans to be sent to Zipkin
with this change we give users a hook to achieve that

fixes gh-1033
@marcingrzejszczak marcingrzejszczak force-pushed the issues_1033_filter_spans branch from 8d6fb07 to dde4b04 Compare July 25, 2018 09:24
@codecov-io
Copy link

codecov-io commented Jul 25, 2018

Codecov Report

Merging #1037 into master will increase coverage by 0.05%.
The diff coverage is 92.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1037      +/-   ##
============================================
+ Coverage     70.87%   70.93%   +0.05%     
- Complexity      637      642       +5     
============================================
  Files           121      121              
  Lines          2819     2828       +9     
  Branches        300      301       +1     
============================================
+ Hits           1998     2006       +8     
  Misses          626      626              
- Partials        195      196       +1
Impacted Files Coverage Δ Complexity Δ
...loud/sleuth/autoconfig/TraceAutoConfiguration.java 91.66% <92.85%> (-0.65%) 20 <7> (+5)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32cacb6...0a9455a. Read the comment docs.

@marcingrzejszczak marcingrzejszczak force-pushed the issues_1033_filter_spans branch from ad6b996 to 97bc7ea Compare July 25, 2018 11:29
@marcingrzejszczak marcingrzejszczak force-pushed the issues_1033_filter_spans branch from 97bc7ea to 0a9455a Compare July 25, 2018 11:29
@codefromthecrypt
Copy link
Contributor

I really like this, but I think firehose mode in brave will land before sleuth 2.1. Let's try to do what we need with this. openzipkin/brave#557

Probably will be something like..

boolean beforeReport(context, spanRecord);

or something where you can skip out like you are now, but you can also mutate the record. This would be invoked regardless of whether the data goes to something like micrometer or zipkin

@marcingrzejszczak
Copy link
Contributor Author

Dropping in favour of Brave changes

@marcingrzejszczak marcingrzejszczak deleted the issues_1033_filter_spans branch March 21, 2019 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a filter that allows to drop spans
4 participants