Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a filter that allows to drop spans #1033

Closed
marcingrzejszczak opened this issue Jul 23, 2018 · 5 comments
Closed

Add a filter that allows to drop spans #1033

marcingrzejszczak opened this issue Jul 23, 2018 · 5 comments
Labels
enhancement
Milestone
2.1.0.M2

Comments

@marcingrzejszczak
Copy link
Contributor

Right now we allow to mutate a Zipkin Span before we send it to Zipkin. Sometimes, however, it could be useful to filter out certain spans.

Adding a filter (SpanFilter?) before the SpanAdjuster would allow to filter out undesired spans.

IMPORTANT ONE MUST NOT DROP SPANS THAT HAVE CHILDREN!
@codefromthecrypt
Copy link
Contributor

used with care this can be helpful until there's another way to do the same.

@codefromthecrypt
Copy link
Contributor

technically someone can do this now by wrapping the reporter.

@codefromthecrypt
Copy link
Contributor

See also openzipkin/zipkin#2072 which is server-side

marcingrzejszczak added a commit that referenced this issue Jul 25, 2018
@marcingrzejszczak
Added SpanFilter
8d6fb07 
without this change we cannot filter out spans to be sent to Zipkin
with this change we give users a hook to achieve that

fixes gh-1033
@marcingrzejszczak marcingrzejszczak added this to the 2.1.0 milestone Jul 25, 2018
@marcingrzejszczak marcingrzejszczak mentioned this issue Jul 25, 2018
Closed
marcingrzejszczak added a commit that referenced this issue Jul 25, 2018
@marcingrzejszczak
Added SpanFilter
dde4b04 
without this change we cannot filter out spans to be sent to Zipkin
with this change we give users a hook to achieve that

fixes gh-1033
@codefromthecrypt
Copy link
Contributor

See #1096

@marcingrzejszczak marcingrzejszczak modified the milestones: 2.1.0.M1, 2.1.0.M2 Nov 2, 2018
@marcingrzejszczak
Copy link
Contributor Author

Closing in favour of #1096

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.1.0.M2
Development

Successfully merging a pull request may close this issue.

Added SpanFilter spring-cloud/spring-cloud-sleuth
2 participants
@codefromthecrypt @marcingrzejszczak