Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video recording iOS #89

Merged
merged 5 commits into from
Nov 4, 2024
Merged

Video recording iOS #89

merged 5 commits into from
Nov 4, 2024

Conversation

YushraJewon
Copy link
Contributor

Add 30s duration for ios video

@YushraJewon YushraJewon self-assigned this Oct 21, 2024
@@ -367,6 +367,7 @@ - (void) initVideoCallback:(CDVInvokedUrlCommand*)command {
[self.commandDelegate sendPluginResult:pluginResult callbackId:command.callbackId];
}

NSTimer *captureTimer;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to line 13

Copy link
Member

@HashirRajah HashirRajah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some problems when video is stopped before 30 sec.
Steps to reproduce bug:
1.

  • start video
  • put app in background
  • open app again
  • after some time app crashes
  • start video capture
  • stop capture
  • start again
  • video will stop before 30s without clicking on stop

Copy link
Member

@dinitri dinitri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@YushraJewon YushraJewon merged commit 0e55296 into master Nov 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants