-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video recording iOS #89
Conversation
src/ios/SimpleCameraPreview.m
Outdated
@@ -367,6 +367,7 @@ - (void) initVideoCallback:(CDVInvokedUrlCommand*)command { | |||
[self.commandDelegate sendPluginResult:pluginResult callbackId:command.callbackId]; | |||
} | |||
|
|||
NSTimer *captureTimer; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move to line 13
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some problems when video is stopped before 30 sec.
Steps to reproduce bug:
1.
- start video
- put app in background
- open app again
- after some time app crashes
- start video capture
- stop capture
- start again
- video will stop before 30s without clicking on stop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Add 30s duration for ios video