Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ultra wide angle camera option #68

Merged
merged 21 commits into from
May 13, 2024
Merged

Ultra wide angle camera option #68

merged 21 commits into from
May 13, 2024

Conversation

dinitri
Copy link
Member

@dinitri dinitri commented Mar 6, 2024

add option to handle ultra wide camera.

option name: captureDevice
values: "wide-angle" | "default"
if not "wide-angle" => "default"

dinitri
dinitri commented Mar 20, 2024
View reviewed changes
src/android/CameraPreviewFragment.java Show resolved Hide resolved
src/android/CameraPreviewFragment.java Show resolved Hide resolved
src/android/CameraPreviewFragment.java Outdated Show resolved Hide resolved
src/android/CameraPreviewFragment.java Outdated Show resolved Hide resolved
src/android/CameraPreviewFragment.java Outdated Show resolved Hide resolved
src/android/CameraPreviewFragment.java Outdated Show resolved Hide resolved
src/android/CameraPreviewFragment.java Outdated Show resolved Hide resolved
src/ios/CameraSessionManager.m Outdated Show resolved Hide resolved
src/ios/CameraSessionManager.m Show resolved Hide resolved
src/ios/CameraSessionManager.m Outdated Show resolved Hide resolved
zfir
zfir reviewed Mar 27, 2024
View reviewed changes
src/ios/CameraSessionManager.m Outdated Show resolved Hide resolved
src/android/CameraPreviewFragment.java Show resolved Hide resolved
dinitri
dinitri commented Apr 1, 2024
View reviewed changes
www/SimpleCameraPreview.js Outdated Show resolved Hide resolved
src/ios/CameraSessionManager.m Outdated Show resolved Hide resolved
dinitri
dinitri commented Apr 1, 2024
View reviewed changes
Copy link
Member Author

@dinitri dinitri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

android part

src/android/CameraPreviewFragment.java Outdated Show resolved Hide resolved
zfir
zfir reviewed Apr 5, 2024
View reviewed changes
src/ios/SimpleCameraPreview.m Outdated Show resolved Hide resolved
src/ios/SimpleCameraPreview.m Outdated Show resolved Hide resolved
www/SimpleCameraPreview.js Show resolved Hide resolved
src/android/CameraPreviewFragment.java Show resolved Hide resolved
src/android/CameraPreviewFragment.java Show resolved Hide resolved
dinitri
dinitri commented Apr 19, 2024
View reviewed changes
Copy link
Member Author

@dinitri dinitri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review not done yet

src/android/CameraPreviewFragment.java Show resolved Hide resolved
src/android/CameraPreviewFragment.java Outdated Show resolved Hide resolved
zfir
zfir reviewed May 3, 2024
View reviewed changes
Copy link
Member

@zfir zfir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments on iOS

src/android/CameraPreviewFragment.java Show resolved Hide resolved
src/android/SimpleCameraPreview.java Outdated Show resolved Hide resolved
src/ios/CameraSessionManager.m Outdated Show resolved Hide resolved
src/ios/CameraSessionManager.m Outdated Show resolved Hide resolved
src/ios/CameraSessionManager.m Outdated Show resolved Hide resolved
zfir
zfir approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@zfir zfir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code good for me. Only the bug on Android:

When rotating in landscape in ultra wide mode. It changes the camera to non ultra wide.

src/android/CameraPreviewFragment.java Show resolved Hide resolved
@parveshneedhoo parveshneedhoo merged commit f65d1b1 into master May 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parveshneedhoo parveshneedhoo parveshneedhoo left review comments

@zfir zfir zfir approved these changes

@YushraJewon YushraJewon Awaiting requested review from YushraJewon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dinitri @zfir @YushraJewon @parveshneedhoo @HashirRajah