Skip to content
This repository has been archived by the owner on Dec 17, 2021. It is now read-only.

feat: create default profile definition in MIB server #56

Merged
merged 8 commits into from
Sep 24, 2021

Conversation

weliasz
Copy link
Contributor

@weliasz weliasz commented Sep 24, 2021

No description provided.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 22685 files.

Valid Invalid Ignored Fixed
23 3 22659 0
Click to see the invalid file list
  • profiles/default.yaml
  • tests/profiles/default.yaml
  • tests/profiles/local.yaml

@@ -0,0 +1,22 @@
profiles:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
profiles:
# Copyright 2021 Splunk Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
profiles:

@@ -0,0 +1,22 @@
profiles:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
profiles:
# Copyright 2021 Splunk Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
profiles:

@@ -0,0 +1,22 @@
profiles:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
profiles:
# Copyright 2021 Splunk Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
profiles:

@@ -0,0 +1,27 @@
profiles:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
profiles:
# Copyright 2021 Splunk Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
profiles:

@weliasz weliasz requested a review from okuzhel September 24, 2021 09:08
@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2021

Codecov Report

Merging #56 (f33a02e) into develop (c7dbd05) will decrease coverage by 0.04%.
The diff coverage is 92.15%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #56      +/-   ##
===========================================
- Coverage    98.26%   98.21%   -0.05%     
===========================================
  Files           32       34       +2     
  Lines         6735     6785      +50     
===========================================
+ Hits          6618     6664      +46     
- Misses         117      121       +4     
Impacted Files Coverage Δ
splunk_connect_for_snmp_mib_server/mib_server.py 22.22% <20.00%> (-0.28%) ⬇️
splunk_connect_for_snmp_mib_server/profiles.py 100.00% <100.00%> (ø)
tests/test_profile_merge.py 100.00% <100.00%> (ø)
tests/test_translator.py 91.57% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7dbd05...f33a02e. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 24, 2021

Expected release notes (by @weliasz)

features:
PR comments (f33a02e)
create default profile definition in MIB server (a770351)
format code (c35f874)
aggregate 'is_metric' and 'return_multimetric' parameters to one -> 'data_format' (0d3d111)
adapt unit tests (7071f33)
refactor code (3b40ca9)
implement support for multimetric data (ce3dfe0)
implement support for multimetric data (52a6812)
improved the dynamic MIB loading (#41) (9114730)

fixes:
build fix (c465e9b)
build fix (44dbdb6)
fix failing build (4528553)
fix failing build (a86393a)
fix failing build (1364f56)
fix failing build (55871bf)
change comment in order to fix CI (#47) (a6e2ce0)
code cleaning (d4afa74)
fixed the cla-assistant version (bed65bf)

others (will not be included in Semantic-Release notes):
fix metadata-action step (#55) (f3ddfb1)
do not include actionlint (c7dbd05)
pre-commit autoupdate [ci skip] (cc42b57)
allow dependabot[bot] (5ed3b86)
add pre-commit step and remove lint step (9fb0595)
1.8.0-develop.1 (acd8b73)
0854c3c code cleaning
c4fc670 Fix build
add pre-commit and fix linter step in CI (#44) (5ace4e0)
a385665 implement support for multimetric data

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@weliasz weliasz requested a review from okuzhel September 24, 2021 12:21
@weliasz weliasz merged commit ed7d8e8 into develop Sep 24, 2021
@weliasz weliasz deleted the feat/profiles_on_mib branch September 24, 2021 15:29
@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2021
@weliasz
Copy link
Contributor Author

weliasz commented Sep 24, 2021

🎉 This PR is included in version 1.8.0-develop.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants