feat: improved the dynamic MIB loading #41

lingy1028 · 2021-07-20T15:44:39Z

No description provided.

- I have just rewritten a very-basic lookup that works. I don't fully understand the mongodb-related part, but at least this should give us a basic point where we can start from.

- Fixed one MIB file name in unit-test

- Fixed one MIB file name in unit-test (and removed useless lookups)

- Fixed the find_mib_file method to add a feature that searching the MIBs using the OID without index

- changed to find/load all mapping MIBs instead of find/load one. - changed unit-test to test HOST-RESOURCES-MIB instead of NETSERVER-MIB. - Note/Finding: After loading all the mapping MIBs, only the last loaded MIB is used to do the translation.

- fixed to lazy load extra MIBs only when the exception is a non-OBJECT-TYPE exception

codecov-commenter · 2021-07-20T15:46:42Z

Codecov Report

Merging #41 (86f01db) into develop (32b315f) will increase coverage by 1.28%.
The diff coverage is 94.73%.

@@             Coverage Diff             @@
##           develop      #41      +/-   ##
===========================================
+ Coverage    97.04%   98.33%   +1.28%     
===========================================
  Files           27       32       +5     
  Lines         5081     6731    +1650     
===========================================
+ Hits          4931     6619    +1688     
+ Misses         150      112      -38

Impacted Files	Coverage Δ
...unk_connect_for_snmp_mib_server/snmp_mib_server.py	`44.11% <50.00%> (+44.11%)`	⬆️
splunk_connect_for_snmp_mib_server/translator.py	`83.58% <96.77%> (+3.48%)`	⬆️
splunk_connect_for_snmp_mib_server/mongo.py	`82.22% <100.00%> (+16.36%)`	⬆️
tests/test_translator.py	`91.83% <100.00%> (+0.17%)`	⬆️
mibs/pysnmp/UCD-SNMP-MIB.py	`100.00% <0.00%> (ø)`
mibs/pysnmp/NETSERVER-MIB.py	`100.00% <0.00%> (ø)`
mibs/pysnmp/HOST-RESOURCES-V2-MIB.py	`100.00% <0.00%> (ø)`
mibs/pysnmp/HCNUM-TC.py	`100.00% <0.00%> (ø)`
mibs/pysnmp/HOST-RESOURCES-MIB.py	`100.00% <0.00%> (ø)`
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32b315f...86f01db. Read the comment docs.

- I have just rewritten a very-basic lookup that works. I don't fully understand the mongodb-related part, but at least this should give us a basic point where we can start from.

- Fixed one MIB file name in unit-test

- Fixed one MIB file name in unit-test (and removed useless lookups)

- Fixed the find_mib_file method to add a feature that searching the MIBs using the OID without index

- changed to find/load all mapping MIBs instead of find/load one. - changed unit-test to test HOST-RESOURCES-MIB instead of NETSERVER-MIB. - Note/Finding: After loading all the mapping MIBs, only the last loaded MIB is used to do the translation.

- fixed to lazy load extra MIBs only when the exception is a non-OBJECT-TYPE exception

…t-for-snmp-mib-server into feature/fix-semgrep

github-actions · 2021-07-20T22:44:52Z

CLA Assistant Lite bot: All contributors have NOT signed the COC Document

I have read the Code of Conduct and I hereby accept the Terms

1 out of 2 committers have signed the CLA.
✅ @lingy1028
❌ @lstoppa
_{You can retrigger this bot by commenting recheck in this Pull Request}

lingy1028 · 2021-07-20T23:11:10Z

I have read the Code of Conduct and I hereby accept the Terms

…and - python3 -m pip install types-PyYAML

github-actions · 2021-07-21T01:48:25Z

Expected release notes (by @lingy1028)

fixes:
added types-PyYAML (86f01db)
dummy commit to resolve lint issue by running suggested pip command - python3 -m pip install types-PyYAML (e0a7249)
reformatted to pass the lint checks (7e16d0a)
removed the failed CI step: Upload result to GitHub Code Scanning (bd58ff3)
partial fix for dynamic MIB loading (f6cad57)
partial fix for dynamic MIB loading (e167cd7)
partial fix for dynamic MIB loading (c3380d6)
removed unexpected argument for yaml.safe_load (7dfb5b5)
partial fix for dynamic MIB loading - Fixed one MIB file name in unit-test (and removed useless lookups) (50b19ca)
partial fix for dynamic MIB loading - Fixed one MIB file name in unit-test (9d55d14)
partial fix for dynamic MIB loading - I have just rewritten a very-basic lookup that works. I don't fully understand the mongodb-related part, but at least this should give us a basic point where we can start from. (b42ee99)
added unit-test for HOST-RESOURCES-MIB (d6a29b9)
(semgrep) use yaml::safe_load instead of yaml::load (cf9123c)
fixed the cla-assistant version (bed65bf)
partial fix for dynamic MIB loading (3d6e791)
partial fix for dynamic MIB loading (d17cfc5)
partial fix for dynamic MIB loading (0c995c4)
removed unexpected argument for yaml.safe_load (fedde57)
partial fix for dynamic MIB loading - Fixed one MIB file name in unit-test (and removed useless lookups) (19f829d)
partial fix for dynamic MIB loading - Fixed one MIB file name in unit-test (13177d4)
partial fix for dynamic MIB loading - I have just rewritten a very-basic lookup that works. I don't fully understand the mongodb-related part, but at least this should give us a basic point where we can start from. (d057539)
added unit-test for HOST-RESOURCES-MIB (a13e76e)
(semgrep) use yaml::safe_load instead of yaml::load (71b32b4)
update python version quotes (d0c8cd4)
update NOTICE (aa41392)
correct image path (975c556)

others (will not be included in Semantic-Release notes):
refactor to remove the duplicate code (8dab52a)
32b315f Feature/addon 39052 (#40)
update copyright header (304d196)
move to actions (#33) (03afb42)

I hereby acknowledge these release notes are 🥙 AWESOME 🥙

lstoppa

Al looks good. I have run on my local environments those tests and all is green. Please merge.

lstoppa · 2021-07-21T06:42:16Z

I have read the Code of Conduct and I hereby accept the Terms

weliasz · 2021-09-01T14:21:25Z

🎉 This PR is included in version 1.8.0-develop.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

lstoppa and others added 9 commits July 16, 2021 09:34

fix: (semgrep) use yaml::safe_load instead of yaml::load

71b32b4

fix: added unit-test for HOST-RESOURCES-MIB

a13e76e

fix: partial fix for dynamic MIB loading

d057539

- I have just rewritten a very-basic lookup that works. I don't fully understand the mongodb-related part, but at least this should give us a basic point where we can start from.

fix: partial fix for dynamic MIB loading

13177d4

- Fixed one MIB file name in unit-test

fix: partial fix for dynamic MIB loading

19f829d

- Fixed one MIB file name in unit-test (and removed useless lookups)

fix: removed unexpected argument for yaml.safe_load

fedde57

fix: partial fix for dynamic MIB loading

0c995c4

- Fixed the find_mib_file method to add a feature that searching the MIBs using the OID without index

fix: partial fix for dynamic MIB loading

3d6e791

- fixed to lazy load extra MIBs only when the exception is a non-OBJECT-TYPE exception

lingy1028 requested review from mayurah, abhagat-splunk, ryanfaircloth and lstoppa July 20, 2021 15:44

lingy1028 and others added 11 commits July 20, 2021 15:17

fix: fixed the cla-assistant version

bed65bf

fix: (semgrep) use yaml::safe_load instead of yaml::load

cf9123c

fix: added unit-test for HOST-RESOURCES-MIB

d6a29b9

fix: partial fix for dynamic MIB loading

b42ee99

- I have just rewritten a very-basic lookup that works. I don't fully understand the mongodb-related part, but at least this should give us a basic point where we can start from.

fix: partial fix for dynamic MIB loading

9d55d14

- Fixed one MIB file name in unit-test

fix: partial fix for dynamic MIB loading

50b19ca

- Fixed one MIB file name in unit-test (and removed useless lookups)

fix: removed unexpected argument for yaml.safe_load

7dfb5b5

fix: partial fix for dynamic MIB loading

c3380d6

- Fixed the find_mib_file method to add a feature that searching the MIBs using the OID without index

fix: partial fix for dynamic MIB loading

f6cad57

- fixed to lazy load extra MIBs only when the exception is a non-OBJECT-TYPE exception

Merge branch 'feature/fix-semgrep' of github.com:splunk/splunk-connec…

4e14c84

…t-for-snmp-mib-server into feature/fix-semgrep

fix: removed the failed CI step: Upload result to GitHub Code Scanning

bd58ff3

lingy1028 added 2 commits July 20, 2021 17:08

refactor: refactor to remove the duplicate code

8dab52a

fix: reformatted to pass the lint checks

7e16d0a

lingy1028 added 2 commits July 20, 2021 18:12

fix: dummy commit to resolve lint issue by running suggested pip comm…

e0a7249

…and - python3 -m pip install types-PyYAML

fix: added types-PyYAML

86f01db

lstoppa approved these changes Jul 21, 2021

View reviewed changes

lstoppa merged commit 9114730 into develop Jul 21, 2021

lstoppa deleted the feature/fix-semgrep branch July 21, 2021 07:30

github-actions bot locked and limited conversation to collaborators Jul 21, 2021

weliasz added the released on @develop label Sep 1, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: improved the dynamic MIB loading #41

feat: improved the dynamic MIB loading #41

lingy1028 commented Jul 20, 2021

codecov-commenter commented Jul 20, 2021 •

edited

Loading

github-actions bot commented Jul 20, 2021 •

edited

Loading

lingy1028 commented Jul 20, 2021

github-actions bot commented Jul 21, 2021 •

edited by lingy1028

Loading

lstoppa left a comment

lstoppa commented Jul 21, 2021

weliasz commented Sep 1, 2021

feat: improved the dynamic MIB loading #41

feat: improved the dynamic MIB loading #41

Conversation

lingy1028 commented Jul 20, 2021

codecov-commenter commented Jul 20, 2021 • edited Loading

Codecov Report

github-actions bot commented Jul 20, 2021 • edited Loading

lingy1028 commented Jul 20, 2021

github-actions bot commented Jul 21, 2021 • edited by lingy1028 Loading

lstoppa left a comment

Choose a reason for hiding this comment

lstoppa commented Jul 21, 2021

weliasz commented Sep 1, 2021

codecov-commenter commented Jul 20, 2021 •

edited

Loading

github-actions bot commented Jul 20, 2021 •

edited

Loading

github-actions bot commented Jul 21, 2021 •

edited by lingy1028

Loading