Skip to content

Commit

Permalink
chore: update nodejs to 20 (#978)
Browse files Browse the repository at this point in the history
  • Loading branch information
vtsvetkov-splunk authored Dec 18, 2023
1 parent 1da206e commit eb6a8ed
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build-test-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ jobs:
strategy:
matrix:
node-version:
- "18"
- "20"
uses: ./.github/workflows/build-ui.yml
with:
node-version: ${{ matrix.node-version }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ jobs:
python-version: 3.7
- uses: actions/setup-node@v3
with:
node-version: "18"
node-version: "20"
- name: install deps
uses: ./.github/actions/cached-ui-deps
with:
node-version: "18"
node-version: "20"
- name: Build Storybook
run: |
cd ui
Expand Down
2 changes: 1 addition & 1 deletion docs/contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Default development branch is `develop`. Please use it for PR
## Build and Test

Prerequisites:
- Node.js >= 18 ([NodeJS](https://nodejs.org/en/download) or use [nvm](https://github.com/nvm-sh/nvm))
- Node.js LTS version ([NodeJS](https://nodejs.org/en/download) or use [nvm](https://github.com/nvm-sh/nvm))
- Yarn Classic (`npm install --global yarn`)
- Poetry 1.5.1. [Installation guide](https://python-poetry.org/docs/#installing-with-the-official-installer)

Expand Down
4 changes: 2 additions & 2 deletions ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,8 @@
"string-width": "^4.2.2"
},
"engines": {
"node": ">=18",
"yarn": "^1"
"node": ">=20.10.0",
"yarn": "^1.22.21"
},
"msw": {
"workerDirectory": "src/public"
Expand Down

0 comments on commit eb6a8ed

Please sign in to comment.