Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update nodejs to 20 #978

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Conversation

vtsvetkov-splunk
Copy link
Contributor

No description provided.

@vtsvetkov-splunk vtsvetkov-splunk marked this pull request as ready for review December 18, 2023 13:14
Copy link
Member

@artemrys artemrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also update https://splunk.github.io/addonfactory-ucc-generator/contributing/#build-and-test?

The node version does not have anything to do with SUI?

@vtsvetkov-splunk
Copy link
Contributor Author

Can you please also update https://splunk.github.io/addonfactory-ucc-generator/contributing/#build-and-test?

The node version does not have anything to do with SUI?

No, it is dev dependency

@vtsvetkov-splunk vtsvetkov-splunk merged commit eb6a8ed into develop Dec 18, 2023
@vtsvetkov-splunk vtsvetkov-splunk deleted the feature/update-node-20 branch December 18, 2023 14:40
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants