Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.9 Release #803

Merged
merged 30 commits into from
Jul 30, 2022
Merged

0.9 Release #803

merged 30 commits into from
Jul 30, 2022

Conversation

nickdnk
Copy link
Collaborator

@nickdnk nickdnk commented Jul 30, 2022

@splewis Final review before 0.9 release.

I will bring in the Hungarian translation (#797) once tested, but that's only a translation file edit. Nothing else will change unless we find a problem that needs fixing.

Key points:

  1. Refactored the pause system. It has been very thoroughly tested and works well.
  2. Fixed a bunch of problems related to coaching, including the game-breaking bug that would put coaches in 3rd person. Valve couldn't fix this it seems, but @PhlexPlexico and I figured it out.
  3. A lot better support for and handling of bots, including putting them in the damage report.
  4. Fixed the problem with scrims and manual matches messing up the MySQL extension as it expects only integer Match IDs.
  5. Fixed some problems related to suicide and dying from the bomb. Also thoroughly tested.
  6. Streamlined CI flow to allow for pre-releases (development branch) and releases (master branch).
  7. Fixed a bunch of translation-related stuff.
  8. Fixed a bug that would cause damage attribution (damage report + grenade victim forwards) to not work if the plug-in was reloaded while users were on the server.
  9. Brought in the update-notice functionality.

This is way better than the current 0.8 master release (which also has no official release), so I suggest we get this released ASAP.

nickdnk and others added 30 commits July 18, 2022 20:43
* Use the user ID in the stat-tracking logic for grenades, as this is unique within the scope of the server. Avoids having to compare steamID strings.
Fix coach placement problems related to auto-joining of teams.
)

* Remove extraneous calls to mp_warmup_pausetimer 1 and mp_do_warmup_period 1 in EnsurePausedWarmup
* Rename EnsurePausedWarmup to more appropriate EnsureIndefiniteWarmup since no pausing takes place
Add bomb parameter to player death event
Make attacker and weapon nullable on player death event
Add self to array of victims for grenades
Refactor suicide logic again
…lve)

Fix bad hooking of SDKHook_OnTakeDamageAlive when bots are in the game
Allow bots to be in damage report
Don't increment stats for bots
Fix SDK rehooking on plugin reload
Remove g_PauseTimeUsed
Only fire necessary timers
Ensure fixed pause configuration takes precedence over combined max pause time
Redirect sm_tech to admin pause if used in console
Prevent direct calls to mp_pause_match and mp_unpause_match, force sm_pause/sm_unpause
Remove g_TeamGivenTechPauseCommand array
Add g_PausingTeam and g_PauseType to debug output
Prevent multiple pauses from being triggered at the same time
Prevent spectators and team none from ever calling pause or unpause
Renamed g_MaxTechPauseTime to g_MaxTechPauseDurationCvar for consistency
Renamed g_MaxPausesCvar to g_MaxTacticalPausesCvar for consistency
Renamed g_TechPausedTimeOverride to g_TechnicalPauseTimeUsed, as that's what it is
Renamed g_TeamPauseTimeUsed to g_TacticalPauseTimeUsed
Renamed g_TechPauseTimeUsed to g_TechnicalPauseTimeUsed
Renamed g_TeamPausesUsed to g_TacticalPausesUsed
Renamed g_TeamTechPausesUsed to g_TechnicalPausesUsed
Add print-to-all localized hints for all pauses, ditched the in-game pause state as it's buggy
Add util function for converting seconds to minutes:seconds
Ensure unpausing when loading a match
Refactored translations and removed redundant chat-text
Allow admin to pause even if pausing is disabled
Add team name to max pause/pause time used.
Add backup pause type hint
Add stop command not enabled translation
Don't allow stop command during admin pause
Automatically unpause if max pauses get set to a lower value than already consumed while a pause is active
Adjust danish translations
Adjust game state pause permissions
Add support for automatic pre-release and release builds on GitHub Actions
Refactor suicide logic to be simpler.
Adjust output filenames to match version
Set commit length to 7 instead of 6 to match changelog tags
Pr head sha for PR build
@nickdnk nickdnk requested review from splewis and PhlexPlexico July 30, 2022 15:30
@nickdnk nickdnk added this to the 0.9 milestone Jul 30, 2022
@splewis
Copy link
Owner

splewis commented Jul 30, 2022

Looks good to me; let's merge it in.

Copy link
Collaborator

@PhlexPlexico PhlexPlexico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@nickdnk nickdnk merged commit b8fd908 into master Jul 30, 2022
@nickdnk nickdnk mentioned this pull request Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants