Fix FeedItem update() use with CarbonImmutable date #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
yipeecaiey
added a commit
to yipeecaiey/laravel-feed
that referenced
this pull request
Sep 11, 2024
* commit '9ba8fde4272c4e149fe56f9fa0f42411942a8c5b': (31 commits) wip wip wip wip Update run-tests.yml wip wip Add changelog workflow (automated commit) Remove misplaced * (spatie#182) Update CHANGELOG.md Fixed FeedItem update() use with CarbonImmutable date (spatie#178) Update CHANGELOG.md Fix config validation (spatie#159) wip do not fail with default config wip wip Package throws an exception when using with Statamic (spatie#155) wip use defaults ... # Conflicts: # .gitignore # src/Feed.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the
FeedItem::update()method after having set Carbon dates as immutable (https://dyrynda.com.au/blog/laravel-immutable-dates), currently causes this error.We can easily solve this by changing the
FeedItem$updated attribute type byCarbonInterfaceinstead ofCarbon=> it solves the error and make this package compatible with CarbonImmutable dates 👍I actually need this PR to be merged because we use your package on our projets. But I am also participating to this Hacktoberfest edition, so if you could tag this PR with
hacktoberfest-acceptedbefore merging, I would be grateful ! (I wouldn't feel offended if you don't).Thanks and keep up the good work !