Package throws an exception when using with Statamic #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Statamic overrides the View instance, which isn't registered yet if you call the ConfigurationValidator in the packageRegistered function.
yipeecaiey
added a commit
to yipeecaiey/laravel-feed
that referenced
this pull request
Jul 8, 2021
* commit '7adb0291acd3483382d43b5bfe68e007faf98b36': (92 commits) Update CHANGELOG.md Fix config validation (spatie#159) wip do not fail with default config wip wip Package throws an exception when using with Statamic (spatie#155) wip use defaults Update links.blade.php improvements drop support for old versions wip wip nitpicks nitpicks Fix styling nitpicks nitpicks PHP 8-only Support, New Features (v4) (spatie#153) ... # Conflicts: # .gitignore # composer.json # src/Feed.php
yipeecaiey
added a commit
to yipeecaiey/laravel-feed
that referenced
this pull request
Sep 11, 2024
* commit '9ba8fde4272c4e149fe56f9fa0f42411942a8c5b': (31 commits) wip wip wip wip Update run-tests.yml wip wip Add changelog workflow (automated commit) Remove misplaced * (spatie#182) Update CHANGELOG.md Fixed FeedItem update() use with CarbonImmutable date (spatie#178) Update CHANGELOG.md Fix config validation (spatie#159) wip do not fail with default config wip wip Package throws an exception when using with Statamic (spatie#155) wip use defaults ... # Conflicts: # .gitignore # src/Feed.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Statamic overrides the View instance, which isn't registered yet if you call the ConfigurationValidator in the packageRegistered function.